Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14_0_X] Skip evaluation of TF model if one of the input tensors is empty #45145

Merged
merged 1 commit into from
Jun 7, 2024

Conversation

valsdav
Copy link
Contributor

@valsdav valsdav commented Jun 5, 2024

Backport of #45139

PR description:

Solves: #44481

Evaluating TensorFlow models with empty tensors is problematic. We observed different behavior on different architectures. It crashes on machines with AVX512 registers available, whereas it works fine and returns empty tensors.
In some cases incompatible shapes for operators are reported by the TF engine.

Related issues: #45136, #44333

This PR introduces a simple check for empty inputs in the central TensorFlow interface to avoid evaluation of the model for empty tensors.

PR validation:

A new test has been added calling the TF inference with empty tensors.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 5, 2024

A new Pull Request was created by @valsdav for CMSSW_14_0_X.

It involves the following packages:

  • PhysicsTools/TensorFlow (ml)

@cmsbuild, @wpmccormack, @valsdav can you please review it and eventually sign? Thanks.
@makortel, @riga this is something you requested to watch as well.
@sextonkennedy, @antoniovilela, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 5, 2024

cms-bot internal usage

@valsdav
Copy link
Contributor Author

valsdav commented Jun 5, 2024

please test

@mmusich
Copy link
Contributor

mmusich commented Jun 5, 2024

urgent

  • needed for data-taking

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 5, 2024

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-574d79/39722/summary.html
COMMIT: 401dcfa
CMSSW: CMSSW_14_0_X_2024-06-05-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/45145/39722/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 5 lines to the logs
  • Reco comparison results: 51 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3338712
  • DQMHistoTests: Total failures: 9
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3338683
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 202 log files, 165 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@missirol
Copy link
Contributor

missirol commented Jun 6, 2024

@cms-sw/ml-l2 , any reason not to sign this ?

@valsdav
Copy link
Contributor Author

valsdav commented Jun 6, 2024

+1
(sorry I thought I did it before)

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 6, 2024

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@antoniovilela
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 3edf308 into cms-sw:CMSSW_14_0_X Jun 7, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants