-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skip evaluation of TensorFlow model if inputs are empty #45139
Conversation
cms-bot internal usage |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-45139/40483
|
A new Pull Request was created by @valsdav for master. It involves the following packages:
@wpmccormack, @valsdav, @cmsbuild can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-50c1e6/39709/summary.html Comparison SummarySummary:
|
urgent
|
+ml |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
Solves: #44481
Evaluating TensorFlow models with empty tensors is problematic. We observed different behavior on different architectures. It crashes on machines with AVX512 registers available, whereas it works fine and returns empty tensors.
In some cases incompatible shapes for operators are reported by the TF engine.
Related issues: #45136, #44333
This PR introduces a simple check for empty inputs in the central TensorFlow interface to avoid evaluation of the model for empty tensors.
PR validation:
A new test has been added calling the TF inference with empty tensors.