Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is there a way to return a view instead of an Image as the placeholder #13

Closed
yixe opened this issue May 14, 2020 · 14 comments
Closed

Is there a way to return a view instead of an Image as the placeholder #13

yixe opened this issue May 14, 2020 · 14 comments
Labels

Comments

@yixe
Copy link

yixe commented May 14, 2020

To add something like a progression animation circle as a placeholder

@yixe yixe changed the title Is there a way to return a view instead of an Image as the placeholder image Is there a way to return a view instead of an Image as the placeholder May 14, 2020
@JonasDeichelmann
Copy link

@cmtrounce I would also be interested in a solution for that. I think your Package is nice to use.

@cmtrounce
Copy link
Owner

I’ll look into this

@JonasDeichelmann
Copy link

@cmtrounce
Did you look at this ticket?

@cmtrounce
Copy link
Owner

cmtrounce commented Jun 14, 2020

Hi @JonasDeichelmann , Yes. I have to change a little bit of the logic under the hood, and observe the progress, so it shouldn't be too much work.

@cmtrounce
Copy link
Owner

@yixe , @JonasDeichelmann , do you have slack accounts?

@JonasDeichelmann
Copy link

@cmtrounce Yes, I do have a Slack account. But on which Workspace?

@cmtrounce
Copy link
Owner

@cmtrounce Yes, I do have a Slack account. But on which Workspace?

@JonasDeichelmann ios-developers

@JonasDeichelmann
Copy link

@cmtrounce What Slack Channel is that?
I guess I need an invitation.

@cmtrounce
Copy link
Owner

@cmtrounce
Copy link
Owner

I'm laying the groundwork now to get this feature going. stay tuned.

@cmtrounce
Copy link
Owner

@JonasDeichelmann / @yixe
0.3.0 (just been released) is the first step towards this. I had to change the underlying views to support AnyView.
Now that's done, it's opened up the flexibility to add support for providing any View as a placeholder.

I'll provide a closure format (percentageComplete) -> some View so you can return whatever you like , based on progress.

@cmtrounce
Copy link
Owner

@yixe do you have a way I can get in contact with you? twitter? slack?

@cmtrounce
Copy link
Owner

@yixe , on the develop branch I've added a function called progress where you can return a view which will display whilst content is loading

@cmtrounce
Copy link
Owner

This has been resolved in release 0.4.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants