Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UIKit Adaptations #616

Merged
merged 51 commits into from
Dec 16, 2020
Merged

UIKit Adaptations #616

merged 51 commits into from
Dec 16, 2020

Conversation

sgratzl
Copy link
Member

@sgratzl sgratzl commented Nov 5, 2020

Prerequisites:

  • Unless it is a hotfix it should be merged against the dev branch
  • Branch is up-to-date with the branch to be merged with, i.e. dev
  • Build is successful
  • Code is cleaned up and formatted

Summary

imports and applies the UIkit into covidcast:

image
image
image

atm. the new version doesn't have a header since it is designed to be embedded into the main website, either as an iframe or directly via the scripts

@netlify
Copy link

netlify bot commented Nov 5, 2020

Preview link ready!

Built with commit 15c5fd6

https://deploy-preview-616--cmu-delphi-covidcast.netlify.app

@sgratzl sgratzl changed the title Sgratzl/uikit UIKit Adaptations Nov 6, 2020
@sgratzl sgratzl changed the title UIKit Adaptations Proof of Concept: UIKit Adaptations Nov 6, 2020
@sgratzl sgratzl marked this pull request as ready for review December 15, 2020 19:06
@sgratzl sgratzl changed the title Proof of Concept: UIKit Adaptations UIKit Adaptations Dec 15, 2020
@sgratzl sgratzl self-assigned this Dec 15, 2020
@dlaliberte
Copy link
Contributor

The changes look good to me, both the source, and the demo.

Copy link
Contributor

@dlaliberte dlaliberte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better to start using this asap, to find problems before the next release.

@Raphael-Hyde
Copy link
Contributor

LGTM - thanks for making these changes, I'll start logging some UX/UI feedback :)

@sgratzl sgratzl merged commit 84210aa into dev Dec 16, 2020
@sgratzl sgratzl deleted the sgratzl/uikit branch December 16, 2020 12:50
@sgratzl sgratzl mentioned this pull request Dec 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants