Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes for 7.6.1. #1708

Merged
merged 16 commits into from
Nov 15, 2023
Merged

Changes for 7.6.1. #1708

merged 16 commits into from
Nov 15, 2023

Conversation

jdramsey
Copy link
Collaborator

Several recent changes.

Updates for 7.6.1 (hotfix):

  1. Fixed a bug introduced in 7.6.0 where, for tiered knowledge, too many edges were forbidden per tier.
  2. Fixed an issue in a snapshot build (not 7.6.0) where you couldn't make a Tiers and Edges editor if you put a knowledge box on the workbench and double-clicked it.
  3. Adding an instruction in the Markov Checker editor that the contents of the table can be copied and pasted into Excel.
  4. Fixed a backward compatibility issue with 7.5.0 for knowledge.
  5. Stamping CPDAG algorithms with both the score used to generate them (where applicable) and standard BIC.
  6. Changed the name of PC-LiNGAM to BOSS-LiNGAM.
  7. Fixed problem with BOSS, GRaSP, etc. code hanging with constant columns.
  8. [Code] Added code to py-tetrad to run the Markov Checker, which required moving the enum ConditioningSetType to a higher level.

@jdramsey jdramsey requested a review from bja43 November 14, 2023 20:33
Copy link
Collaborator

@bja43 bja43 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked:

  • If you can load Clark’s session and run it on the first dataset, then issues 4 and 7 are fixed.
  • If you can load Sisi’s dataset and run GRaSP-FCI and don’t get a slew of bidirected edges, then issue 1 is fixed.
  • If you can put an empty knowledge box on the workbench and double click it and make a Tiers and Edges gadget then 2 is fixed
  • If you run BOSS and it tells you the final score and BIC score, then 5 is fixed

and these things look to be working.

@jdramsey jdramsey merged commit 2ec8349 into development Nov 15, 2023
@jdramsey jdramsey deleted the joe-work-11-5-2023 branch November 15, 2023 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants