Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bring back 2D views #115

Open
xnought opened this issue Mar 14, 2023 · 5 comments
Open

bring back 2D views #115

xnought opened this issue Mar 14, 2023 · 5 comments
Assignees
Labels
enhancement ✨ New feature or request on hold

Comments

@xnought
Copy link
Member

xnought commented Mar 14, 2023

We only have 1D views right now because the code for 1D is quite complex with the additions of categorical data too. First simplify 1D, then add 2D.

@xnought xnought added the enhancement ✨ New feature or request label Mar 14, 2023
@xnought xnought self-assigned this Mar 14, 2023
@xnought xnought added the priority ☄️ Working on it! High priority! label Mar 14, 2023
@xnought xnought removed the priority ☄️ Working on it! High priority! label Apr 3, 2023
@Unemyr
Copy link

Unemyr commented Aug 31, 2023

Hi, would just like to check if there is any update or more concrete plans to add back the 2D view support? Thanks in advance!

@xnought
Copy link
Member Author

xnought commented Aug 31, 2023

No concrete plans at the moment or in the near future. My bad for not updating the original issue.

@Unemyr
Copy link

Unemyr commented Sep 1, 2023

No worries - thank you for the quick reply! I may not be familiar enough with this library to make the appropriate amendments myself, but if I were to have a go at it, would it be possible to get some rough guidance/a few key points on where/what changes would likely need to be made? Cheers, Erik

@xnought
Copy link
Member Author

xnought commented Sep 8, 2023

I might check out https://uwdata.github.io/mosaic/ if you're using duckdb stuff. You can get the same logic, but the 2D stuff is already implemented.

For falconvis, The implementation will be reasonably complex. That's the whole reason I'm not implementing it right now.

But what I would personally do is pick the data source I plan to use (arrow, duckdb, or other) and change the db file to also include a way to compute the 2D falcon index given two dimensions. https://github.com/cmudig/falcon-vis/tree/main/falcon-vis/src/db

Then add a custom View2D class which fetches that index and can subsequently be used given a filter. https://github.com/cmudig/falcon-vis/blob/main/falcon-vis/src/falcon.ts

I wish it could be easier. I'll see what I can do in the next few weeks, but no promises.

@Unemyr
Copy link

Unemyr commented Sep 18, 2023

Thank you - I would definately offer to help do some additional testing on the new version, in ways I could contribute!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement ✨ New feature or request on hold
Projects
None yet
Development

No branches or pull requests

2 participants