-
Notifications
You must be signed in to change notification settings - Fork 468
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tree width options #1018
Add tree width options #1018
Conversation
A few notes:
|
df48127
to
49fd3cb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested tree/library/playlist views, mouse events, resizing window, setting window size from rc/autosave/command-line/remote.
IMO it's better to handle the width in columns since that is the basic underlying unit.' |
What do you think of renaming it to |
sounds good |
Actually, I think I have a better idea: adding an optional |
Also a good option. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested tree/library/playlist views, mouse events, resizing window, setting window size from rc/autosave/command-line/remote with:
tree_width_percent=100
tree_width_max=60
tree_width_percent=33
tree_width_max=60
tree_width_percent=33
tree_width_max=0
tree_width_percent=1
tree_width_max=9999
@nefthy, this is ready for review now. |
I took a closer look at the code, and I'm now fairly certain this won't cause issues elsewhere. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but please rebase, as there is a conflict with another merge
thanks |
closes #990
closes #772