Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CMUS_SOCKET environment variable. #68

Closed
wants to merge 2 commits into from

Conversation

pnelson
Copy link
Contributor

@pnelson pnelson commented Oct 19, 2013

This lets you set an entirely different path for the socket file. I don't really think it belongs with my config files, and I'd actually prefer it to just sit in /tmp.

The changes are pretty minimal and I included the documentation. What do you think?

@mahkoh
Copy link
Member

mahkoh commented Oct 19, 2013

Being able to set CMUS_SOCKET in an envvar would be very useful to me.

See #33, though.

@flyingmutant
Copy link
Member

Can you please explain what is the use case for this feature, and if e.g. supporting $XDG_RUNTIME_DIR would be enough for this?

@pnelson
Copy link
Contributor Author

pnelson commented Oct 21, 2013

I just don't want my socket in my config directory, mostly for semantic reasons (it isn't a configuration file). I've been putting most of my sockets/fifos in tmp.

Supporting $XDG_RUNTIME_DIR would suffice, so maybe I should work towards #33 instead.

@flyingmutant
Copy link
Member

If you'll start doing that, please take great care to ensure backward compatibility.

@flyingmutant
Copy link
Member

See #69.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants