Support XDG directories with backwards compatibility. Fixes #33. #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To determine where the configuration files are located, the logic is as follows: - CMUS_HOME takes priority, as before. - ~/.cmus is used if it already exists, to maintain backward compatibility. - New users default to XDG_CONFIG_HOME/cmus, or ~/.config/cmus if XDG_CONFIG_HOME is unset. To determine where the socket is located is a bit more simple: - XDG_RUNTIME_DIR/cmus-socket if XDG_RUNTIME_DIR is set. - Otherwise, name it 'socket' in the config directory, as before.
|
Adding to the discussion in #33, |
|
Can you please update the cmus documentation as well? |
|
I think that covers it all. I updated the documentation such that it reflects the new version, going forward. |
|
Oh, I am very sorry for not replying for so long — for some reason I missed the Github notification that this was updated 4 days ago! |
| @@ -230,7 +231,7 @@ enum flags { | |||
| " or: %s\n" | |||
| "Control cmus through socket.\n" | |||
| "\n" | |||
| " --server ADDR connect using ADDR instead of ~/.cmus/socket\n" | |||
| " --server ADDR connect using ADDR instead of $XDG_RUNTIME_DIR/socket\n" | |||
There was a problem hiding this comment.
Should be $XDG_RUNTIME_DIR/cmus-socket, but I'll fix this myself.
|
Thank you a lot! Merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To determine where the configuration files are located, the logic
is as follows:
compatibility.
XDG_CONFIG_HOME is unset.
To determine where the socket is located is a bit more simple: