Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate duffle driver implementations to cnab-go #49

Closed
jlegrone opened this issue Jun 24, 2019 · 2 comments · Fixed by #53
Closed

Migrate duffle driver implementations to cnab-go #49

jlegrone opened this issue Jun 24, 2019 · 2 comments · Fixed by #53

Comments

@jlegrone
Copy link
Member

The driver interface is already defined in the driver package. Many of the driver implementations from duffle are generally useful outside of duffle and should be made available without the need for declaring a dependency on duffle.

@jlegrone
Copy link
Member Author

While the APIs in cnab-go are fairly new, this would also help minimize the downstream impacts of refactors like #28.

@silvin-lubecki
Copy link
Contributor

I agree with moving the drivers here, as it's a main concept in CNAB implementations, and sharing common code between all CNAB runtime clients will reduce interoperability issues 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants