feat: install prototype #47

technosophos · 2018-08-18T21:13:53Z

This is a prototype of duffle install that has two different drivers, one of which is a basic Docker driver.

With the docker driver, you can actually run the install target on a CNAB image:

$ duffle install myname technosophos/helloworld:0.1.0

It is possible to inject driver-specific configuration via environment variables. While this is basically a demo for this release, it will be very important for ACI support. Run duffle install -h for more.

Depends on #46

NB: I'm home basically by myself today with nothing else to do, so I hereby declare that this does not count as working on a Saturday.

radu-matei · 2018-08-20T12:28:07Z

cmd/duffle/install.go

+	  - VERBOSE: "true" turns on extra output
+
+Example:
+	$ VERBOSE=true duffle install -d docker  install my_release duffle/example:0.1.0


Just nitpicking, but this doesn't work on Windows... Environment variables have to be passed through either set in CMD, or $Env: in PowerShell.

so would it be:

$> set VERBOSE=true $> duffle install -d docker install my_release duffle/example:0.1.0

Yeah, that or

$ $env:VERBOSE = true $ duffle install -d docker install my_release duffle/example:0.1.0

I'm not sure if the Windows community uses Powershell or CMD more often, but your comment looks good.

radu-matei · 2018-08-20T14:46:35Z

cmd/duffle/install.go

+		},
+	}
+
+	//cmd.Flags().StringSliceP("credentials", "c", []string{}, "Specify one or more credential sets")


Is this where we would provide a credential set?

technosophos · 2018-08-20T18:58:53Z

I'm going to write up some better documentation on how all of this works. I realize, looking back, that there is a lot of stuff going on here.

radu-matei · 2018-08-21T00:45:23Z

Whenever I try to run this I get:

radu:duffle$ ./bin/duffle install bundle radu/helloworld:latest
standard_init_linux.go:190: exec user process caused "no such file or directory"

Error: exit status 1
Usage:
  duffle install NAME BUNDLE [flags]

Flags:
  -d, --driver string       Specify a driver name (default "docker")
  -h, --help                help for install
  -p, --parameters string   Specify file containing parameters. Formats: toml, MORE SOON

duffle: fatal: exit status 1

technosophos · 2018-08-21T01:31:21Z

@radu-matei can you add -d debug on that and rerun?

Right now it is shelling out to the docker CLI, and based on the error above, I am wondering if it is not finding docker on $PATH or if something in the payload is causing Docker to croak. -d debug will dump the payload that it has prepared. Or adding the env var VERBOSE=true will cause the Docker driver to dump the Docker settings right before executing docker.

Actually, that later one will be very useful because it will show all of the arguments it is passing to Docker.

radu-matei · 2018-08-21T13:56:42Z

I built an image based on the Dockerifle in example/helloworld, and it doesn't appear to find /app/run:

radu:duffle$ VERBOSE=true ./bin/duffle install bundle radu/helloworld:latest
--------> args
run
-e
CNAB_INSTALLATION_NAME=bundle
-e
CNAB_ACTION=install
-e
CNAB_BUNDLE_NAME=radu/helloworld:latest
radu/helloworld:latest
/cnab/app/run
<-------- args
standard_init_linux.go:190: exec user process caused "no such file or directory"

Error: exit status 1
Usage:
  duffle install NAME BUNDLE [flags]

Flags:
  -d, --driver string       Specify a driver name (default "docker")
  -h, --help                help for install
  -p, --parameters string   Specify file containing parameters. Formats: toml, MORE SOON

duffle: fatal: exit status 1

technosophos · 2018-08-21T14:10:12Z

If you do docker run -e CNAB_INSTALLATION_NAME=bundle -e CNAB_ACTION=install -e CNAB_BUNDLE_NAME=radu/helloworld:latest radu/helloworld:latest /cnab/app/run, do you get the same error?

radu-matei · 2018-08-21T14:27:22Z

If I exec manually in the container:

/ # sh /cnab/app/run
: not foundun: line 2:
: not foundun: line 4:
: not foundun: line 6:
: not foundun: line 7:
/cnab/app/run: line 8: syntax error: unexpected word (expecting "in")
/ # ./cnab/app/run
sh: ./cnab/app/run: not found

radu-matei

This appears to be a Windows-only issue. I think it's ok to merge for now and track down what is failing on Windows later.

LGTM

bacongobbler

one minor design comment we may wanna discuss after the POC, but LGTM for a POC :)

bacongobbler · 2018-08-21T15:36:59Z

cmd/duffle/install.go

+}
+
+func validateDockerish(s string) error {
+	if !strings.Contains(s, ":") {


with this requirement, it means we can never imply that duffle install my_release duffle/example implies the latest version. Is there a way we can loosen this requirement, or is this intentional by design?

This provides a prototype implementation of `duffle install` that should make it possible to easily create verbs for each of the CNAB actions. Signed-off-by: Matt Butcher <matt.butcher@microsoft.com>

This can now actually run installs of CNAB images

technosophos self-assigned this Aug 18, 2018

radu-matei reviewed Aug 20, 2018

View reviewed changes

technosophos force-pushed the feat/install-prototype branch from aa0414a to 4fe2bb1 Compare August 20, 2018 20:35

This was referenced Aug 20, 2018

Go: duffle uninstall #58

Closed

Go: duffle upgrade #59

Closed

Go: duffle status #60

Closed

Research: Write a nomad driver #61

Closed

radu-matei approved these changes Aug 21, 2018

View reviewed changes

bacongobbler approved these changes Aug 21, 2018

View reviewed changes

technosophos added 5 commits August 21, 2018 14:24

feat: prototype a 'duffle install' command

d958692

This provides a prototype implementation of `duffle install` that should make it possible to easily create verbs for each of the CNAB actions. Signed-off-by: Matt Butcher <matt.butcher@microsoft.com>

feat: add real Docker driver

791384b

This can now actually run installs of CNAB images

docs: Add documentation and make associated fixes

2ef0c37

feat: add support for external drivers

4d636f3

fix: fixed makefile I broke during rebase

edd3e22

technosophos force-pushed the feat/install-prototype branch from 6daf1b4 to edd3e22 Compare August 21, 2018 20:28

technosophos merged commit aa1d2a6 into cnabio:master Aug 21, 2018

technosophos deleted the feat/install-prototype branch August 21, 2018 20:29

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: install prototype #47

feat: install prototype #47

technosophos commented Aug 18, 2018

radu-matei Aug 20, 2018

technosophos Aug 20, 2018

bacongobbler Aug 20, 2018 •

edited

Loading

radu-matei Aug 20, 2018

technosophos Aug 20, 2018

technosophos commented Aug 20, 2018

radu-matei commented Aug 21, 2018

technosophos commented Aug 21, 2018 •

edited

Loading

radu-matei commented Aug 21, 2018 •

edited

Loading

technosophos commented Aug 21, 2018

radu-matei commented Aug 21, 2018

radu-matei left a comment

bacongobbler left a comment

bacongobbler Aug 21, 2018

feat: install prototype #47

feat: install prototype #47

Conversation

technosophos commented Aug 18, 2018

radu-matei Aug 20, 2018

Choose a reason for hiding this comment

technosophos Aug 20, 2018

Choose a reason for hiding this comment

bacongobbler Aug 20, 2018 • edited Loading

Choose a reason for hiding this comment

radu-matei Aug 20, 2018

Choose a reason for hiding this comment

technosophos Aug 20, 2018

Choose a reason for hiding this comment

technosophos commented Aug 20, 2018

radu-matei commented Aug 21, 2018

technosophos commented Aug 21, 2018 • edited Loading

radu-matei commented Aug 21, 2018 • edited Loading

technosophos commented Aug 21, 2018

radu-matei commented Aug 21, 2018

radu-matei left a comment

Choose a reason for hiding this comment

bacongobbler left a comment

Choose a reason for hiding this comment

bacongobbler Aug 21, 2018

Choose a reason for hiding this comment

bacongobbler Aug 20, 2018 •

edited

Loading

technosophos commented Aug 21, 2018 •

edited

Loading

radu-matei commented Aug 21, 2018 •

edited

Loading