This repository has been archived by the owner on May 3, 2022. It is now read-only.
fixes #658 #659
Merged
fixes #658 #659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
radu-matei
reviewed
Mar 11, 2019
| @@ -82,14 +82,14 @@ type ImagePlatform struct { | |||
|
|
|||
| // Image describes a container image in the bundle | |||
| type Image struct { | |||
| BaseImage | |||
| BaseImage `mapstructure:",squash"` | |||
There was a problem hiding this comment.
Nice catch here!
I do have two questions regarding this change:
- any particular reason you didn't include the
jsontag as well? - we haven't used
squashfor fields so far -- could you, please, include a couple of sentences why we need to add it, and why it's inconsistent with all other fields in the bundle?
Thanks!
There was a problem hiding this comment.
any particular reason you didn't include the json tag as well?
using squash causes the other structure to basically be inlined, as a result the json tag from the BaseImage struct will be used.
we haven't used squash for fields so far -- could you, please, include a couple of sentences why we need to add it, and why it's inconsistent with all other fields in the bundle?
As described in the bug #658, not having the squash tag prevents the Image from marshalling the fields of the BaseImage struct.
radu-matei
reviewed
Mar 11, 2019
|
Somehow I missed this PR, so it should merge before #662 and I will rebase that one afterward |
radu-matei
approved these changes
Mar 14, 2019
michelleN
approved these changes
Mar 14, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
enable Unmarshalling of "Images" in duffle.json