Skip to content
This repository has been archived by the owner on May 3, 2022. It is now read-only.

empty images section in duffle bundle #658

Closed
sbawaska opened this issue Feb 27, 2019 · 2 comments
Closed

empty images section in duffle bundle #658

sbawaska opened this issue Feb 27, 2019 · 2 comments
Assignees

Comments

@sbawaska
Copy link
Contributor

A duffle.json with an images section builds successfully, however, the duffle bundle show does not carry values for the images section. This results in duffle export throwing an error.
sample duffle.json

{
    "name": "kab",
    "version": "0.1.0",
    "description": "A short description of your bundle",
    "keywords": [
        "cnab",
        "kab"
    ],
    "maintainers": [
        {
            "name": "Swapnil Bawaskar",
            "email": "foo@pivotal.io",
            "url": "https://example.com"
        }
    ],
    "invocationImages": {
        "cnab": {
            "name": "cnab",
            "builder": "docker",
            "configuration": {
                "registry": "sbawaska"
            }
        }
    },
    "images": {
        "istio": {
            "description": "istio images",
            "imageType": "docker",
            "image": "docker.io/istio/citadel:1.0.2",
            "digest": "sha256:ca4050c9fed3a2ddcaef32140686613c4110ed728f53262d0a23a7e17da73111"
        }
    },
    "parameters": null,
    "credentials": null
}

After building:

$ duffle bundle show kab
{
    "name": "kab",
    "version": "0.1.0",
    "description": "A short description of your bundle",
    "keywords": [
        "cnab",
        "kab"
    ],
    "maintainers": [
        {
            "name": "Swapnil Bawaskar",
            "email": "foo@pivotal.io",
            "url": "https://example.com"
        }
    ],
    "invocationImages": [
        {
            "imageType": "docker",
            "image": "sbawaska/kab-cnab:37ef8c95617299bffc8ff880e1ec17f5c78ee168",
            "platform": {}
        }
    ],
    "images": {
        "istio": {
            "imageType": "",
            "image": "",
            "platform": {},
            "description": "istio images",
            "refs": null
        }
    },
    "parameters": null,
    "credentials": null
}
@technosophos
Copy link
Member

What is the output of duffle bundle list | grep kab ?

@technosophos
Copy link
Member

technosophos commented Mar 11, 2019

Okay, I just reproduced this locally.

Update: And reproduced on the actions field as well.

technosophos added a commit to technosophos/duffle that referenced this issue Mar 11, 2019
Some duffle files were not unmarshalling correctly. In addition, there were several missing attributes in the bundle and manifest descriptions.

Cleaned up some tests along the way.

Thnks to @sbawaska  for pointing out the critical change

Closes cnabio#658
@ghost ghost assigned technosophos Mar 11, 2019
@ghost ghost added the review label Mar 11, 2019
@sbawaska sbawaska mentioned this issue Mar 12, 2019
@ghost ghost removed the review label Mar 14, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants