-
Notifications
You must be signed in to change notification settings - Fork 554
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Roll out CLABot to Kubernetes #1
Comments
Hey @emsearcy, can you add https://github.com/kubernetes/pr-bot as another repo to the CNCF CLABot so we can move the testing into the Kubernetes organization. |
Thanks @dankohn. Chris and I have communicated via email and we've granted access to the pr-bot repository in the kubernetes org. |
Looks like our first step has been successful. Thanks @caniszczyk.
|
(sorry about the extra notifications) An update for @dankohn from a meeting I had with @foxish.
|
(meant to send this yesterday but looks like I never hit "Comment") Example pull request with multiple authors (pass and fail) including a commit lacking a GitHub author: (Github only uses the status of the last commit in the series, so we propagate failures through to children commits, where the message for a given commit is the status of that commit, plus a count of failed authors from earlier commits in the patch series.) Is this workable for the mungebot you are running to set labels and post messages? |
OK, the pull request web service is live now. We have monitoring set up for it—if you want to monitor it yourself you can hit a simple ping responder which is separate from the github API endpoint but in the same Go service: cncf/demo and kubernetes/pr-bot have had the polling Perl script shutdown, and have been configured with a web hook so that the new LF CLA check will immediately post statuses. I have not yet set it up to update the statuses when the user signs the CLA, so "I signed it" is, for the moment, still needed. |
@emsearcy Sounds good! The example PR you showed looks good as well. The mungebot can handle the labels and comments. We would just need the status to be set, which appears to be happening. I'll set up the bot to do the CLA labeling and commenting later today on pr-bot. Thanks. |
@emsearcy I just tried a test deployment on pr-bot. Please see https://github.com/kubernetes/pr-bot/pull/3#issuecomment-243205552 cc @bgrant0607 |
Update: In an email discussion, we found that there was an issue with the way the CLA check is implemented currently on the CNCF side. We will continue with deployment once the issues are addressed. |
@emsearcy @caniszczyk Any updates so far on fixing the issue we found in the CNCF contributor validation? cc @dankohn |
@emsearcy @caniszczyk Could you please provide an update on the status here? |
I believe @emsearcy will followup soon, he was out on vacation for the last week. Thanks for your patience. |
Thank you for your patience. I've been communicating with our developer team on this and they have completed implementing and testing a hotfix for the issue. They'll deploy it 6pm EDT today. |
@emsearcy Is the fix live at this point? Can we proceed with migrating the CLA system? |
Yes, the fix for email validation behavior on GitHub-based account registration is live. |
@emsearcy Could you please provide an overview on the status. What are the open issues preventing a rollout to K8s or other projects? Are there nice-to-haves we want to add in the future? |
The rollout is now complete and the kubernetes and kubernetes-incubator organizations are using the CNCF CLA. Thanks @caniszczyk, @emsearcy and @dankohn for all the help. |
Thanks all! |
Can we add this check to kubernetes-client org too? |
12/3/15 - added Gold membership level * Changes to sections 4 and 5
Update Maintainers of OpenEBS in project-maintainers.csv
This issue will track progress of rolling out the CLA Bot fully to Kubernetes (see this issue for previous discussion: cncf/demo#7) and this Google doc (https://docs.google.com/document/d/1LIwyn5PDSYu8kh-7hH8688lt1cvwATkZmhec13nhp1c/edit#).
This blocks issue: kubernetes/kubernetes#27796
The text was updated successfully, but these errors were encountered: