Skip to content
This repository has been archived by the owner on Mar 30, 2023. It is now read-only.

Same user, different case? #1101

Closed
svrnm opened this issue Jul 6, 2022 · 8 comments
Closed

Same user, different case? #1101

svrnm opened this issue Jul 6, 2022 · 8 comments
Assignees

Comments

@svrnm
Copy link
Contributor

svrnm commented Jul 6, 2022

Hi,

I am not sure how to fix this, so I am raising this issue: looking at this dashboard, I see two users being listed twice (WPH95, wph95 & Arbiv, arbiv).

They are the same users, is there a way to "merge" them?

Thanks,

cc: @wph95 , @arbiv

@lukaszgryglicki lukaszgryglicki self-assigned this Jul 6, 2022
@lukaszgryglicki
Copy link
Member

Will take a look when I have some time.

@svrnm
Copy link
Contributor Author

svrnm commented Jul 6, 2022

Will take a look when I have some time.

Thank you!

@lukaszgryglicki
Copy link
Member

First question would be if GitHub distinguish case or not.
Can take a look Friday the earliest.

@lukaszgryglicki
Copy link
Member

So users aren't duplicated in GitHub_users.json and cncf-config/email-map - but they are in the dashboard, investigating this.

@lukaszgryglicki
Copy link
Member

But on the database:

opentelemetry=# select * from gha_actors where id > 0 and (upper(login) = 'WPH95' or lower(login) = 'arbiv');
    id    | login |     name     | country_id | sex | sex_prob | tz | tz_offset | country_name | age 
----------+-------+--------------+------------+-----+----------+----+-----------+--------------+-----
 12132333 | Arbiv | Yosef Arbiv  |            |     |          |    |           |              |    
 12132333 | arbiv | Yosef Arbiv  |            |     |          |    |           |              |    
  2732352 | wph95 | Penghan Wang | ni         |     |          |    |           | Nicaragua    |    
  2732352 | WPH95 | Penghan Wang | ni         |     |          |    |           | Nicaragua    |    
(4 rows)

opentelemetry=# 

This means users were renamed somewhere in the past.
I will update dashboard to group by lower(login) which should solve the issue - I'll chekc this locally first.

@lukaszgryglicki
Copy link
Member

This commit should solve this, but I need to test locally, confirm it works, rebuild images and rebuild that dashboard's data.

@lukaszgryglicki
Copy link
Member

Fixed and regenerated data, closing.

@svrnm
Copy link
Contributor Author

svrnm commented Jul 8, 2022

thank you @lukaszgryglicki for looking into this and fixing it!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants