Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tw] Add content/zh-tw/cluster.md #2020

Merged
merged 1 commit into from
May 22, 2023
Merged

Conversation

pichuang
Copy link
Contributor

Origin content from https://glossary.cncf.io/cluster/

Describe your changes

Add new translations term - cluster

Related issue number or link (ex: resolves #issue-number)

resolves #2019

Checklist before opening this PR (put x in the checkboxes)

  • This PR does not contain plagiarism
    • don’t copy other people’s work unless you are quoting and contributing it to them.
  • I have signed off on all commits
    • signing off (ex: git commit -s) is to affirm that commits comply DCO. If you are working locally, you could add an alias to your gitconfig by running git config --global alias.ci "commit -s".

@pichuang pichuang requested a review from ydFu as a code owner May 11, 2023 10:08
@netlify
Copy link

netlify bot commented May 11, 2023

Deploy Preview for cncfglossary ready!

Name Link
🔨 Latest commit 66c691c
🔍 Latest deploy log https://app.netlify.com/sites/cncfglossary/deploys/6466531cd9bf5a00075c655f
😎 Deploy Preview https://deploy-preview-2020--cncfglossary.netlify.app/zh-tw/cluster
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@pichuang pichuang changed the title Add content/zh-tw/cluster.md [tw] Add content/zh-tw/cluster.md May 11, 2023
@pichuang pichuang added the lang/tw for Traditional Chinese label May 11, 2023
Copy link

@ching-kuo ching-kuo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution, left some comments on the translations.

content/zh-tw/cluster.md Outdated Show resolved Hide resolved
content/zh-tw/cluster.md Outdated Show resolved Hide resolved
content/zh-tw/cluster.md Outdated Show resolved Hide resolved
content/zh-tw/cluster.md Outdated Show resolved Hide resolved
@pichuang
Copy link
Contributor Author

Will do squash 1 commit before merge PR

@pichuang pichuang force-pushed the pichuang-cluster branch 2 times, most recently from 0356df4 to ef58dda Compare May 12, 2023 09:37
content/zh-tw/cluster.md Outdated Show resolved Hide resolved
content/zh-tw/cluster.md Outdated Show resolved Hide resolved
content/zh-tw/cluster.md Outdated Show resolved Hide resolved
content/zh-tw/cluster.md Outdated Show resolved Hide resolved
content/zh-tw/cluster.md Outdated Show resolved Hide resolved
content/zh-tw/cluster.md Outdated Show resolved Hide resolved
content/zh-tw/cluster.md Outdated Show resolved Hide resolved
@pichuang pichuang linked an issue May 15, 2023 that may be closed by this pull request
content/zh-tw/cluster.md Outdated Show resolved Hide resolved
Add content/zh-tw/cluster.md

Origin content from https://glossary.cncf.io/cluster/

Signed-off-by: Phil Huang <phil.huang@microsoft.com>
Copy link
Collaborator

@ydFu ydFu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,thank @pichuang

@pichuang
Copy link
Contributor Author

It appears that additional approvers are required in order to approve this PR successfully.

@pichuang
Copy link
Contributor Author

pichuang commented May 22, 2023

Hi @seokho-son As there are currently only 2 zh-tw approvers, and I'm unable to approve my own PR, could you please assist in approving this PR?

@ydFu
Copy link
Collaborator

ydFu commented May 22, 2023

LGTM,Thanks @seokho-son.

@ydFu ydFu merged commit 9ded470 into cncf:dev-tw May 22, 2023
6 checks passed
@seokho-son
Copy link
Collaborator

@pichuang Sure! :)

(please find a nice candidate for the new approver !)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lang/tw for Traditional Chinese
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[tw] Localize Cluster for Traditional Chinese
6 participants