-
Notifications
You must be signed in to change notification settings - Fork 531
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[tw] Add content/zh-tw/cluster.md #2020
Conversation
✅ Deploy Preview for cncfglossary ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution, left some comments on the translations.
Will do squash 1 commit before merge PR |
0356df4
to
ef58dda
Compare
66290e5
to
2294549
Compare
Add content/zh-tw/cluster.md Origin content from https://glossary.cncf.io/cluster/ Signed-off-by: Phil Huang <phil.huang@microsoft.com>
2294549
to
66c691c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM,thank @pichuang
It appears that additional approvers are required in order to approve this PR successfully. |
Hi @seokho-son As there are currently only 2 zh-tw approvers, and I'm unable to approve my own PR, could you please assist in approving this PR? |
LGTM,Thanks @seokho-son. |
@pichuang Sure! :) (please find a nice candidate for the new approver !) |
Origin content from https://glossary.cncf.io/cluster/
Describe your changes
Add new translations term - cluster
Related issue number or link (ex:
resolves #issue-number
)resolves #2019
Checklist before opening this PR (put
x
in the checkboxes)git commit -s
) is to affirm that commits comply DCO. If you are working locally, you could add an alias to yourgitconfig
by runninggit config --global alias.ci "commit -s"
.