Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

conformance results for v1.13/kind #451

Merged
merged 1 commit into from Jan 25, 2019
Merged

Conversation

@BenTheElder
Copy link
Contributor

@BenTheElder BenTheElder commented Jan 23, 2019

https://github.com/kubernetes-sigs/kind

@luxas
Copy link
Contributor

@luxas luxas commented Jan 23, 2019

Thanks @BenTheElder for submitting!

Loading

@taylorwaggoner
Copy link
Contributor

@taylorwaggoner taylorwaggoner commented Jan 23, 2019

@BenTheElder thanks for submitting! The results look great! Could you please submit a signed participation form so that we have contact info on file? You can mark Nonprofit on the form, as there won't be a fee involved. https://github.com/cncf/k8s-conformance/tree/master/participation-form

Thanks!

Loading

@BenTheElder
Copy link
Contributor Author

@BenTheElder BenTheElder commented Jan 24, 2019

Absolutely, taking a look now, thank you!

EDIT: I think I need to run this by legal at work first, will follow up when possible.

Loading

@dankohn
Copy link
Contributor

@dankohn dankohn commented Jan 25, 2019

I've confirmed with LF legal that we don't need a signed participation agreement since kind is part of Kubernetes. Sorry for extra delay. We'll approve shortly.

Cc @swinslow

Loading

@BenTheElder
Copy link
Contributor Author

@BenTheElder BenTheElder commented Jan 25, 2019

Thank you @dankohn 🙏 -- after some further discussion, I wasn't sure if I even needed to? But I'd been waiting for a response from someone with more authority than I 😅

Loading

@taylorwaggoner
Copy link
Contributor

@taylorwaggoner taylorwaggoner commented Jan 25, 2019

You are now Certified Kubernetes
cncf/landscape#1092

Loading

@taylorwaggoner taylorwaggoner merged commit bc371ef into cncf:master Jan 25, 2019
@BenTheElder
Copy link
Contributor Author

@BenTheElder BenTheElder commented Jan 25, 2019

Awesome!! Thank you all! 😄

Loading

@BenTheElder BenTheElder deleted the kind-113 branch Jan 25, 2019
@dankohn
Copy link
Contributor

@dankohn dankohn commented Jan 25, 2019

You categorized kind as a distribution, but I think we would classify it as an installer, since it is using vanilla, upstream Kubernetes. Agree?

https://github.com/cncf/k8s-conformance/blob/master/faq.md#what-is-a-distribution-hosted-platform-and-an-installer

Loading

@BenTheElder
Copy link
Contributor Author

@BenTheElder BenTheElder commented Jan 25, 2019

I was not sure on this and followed kops, which is similar and is also listed as a distribution.

Will defer to you on which is correct. It certainly sounds like installer might make more sense.


Additional context:

We provide pre-built docker "node" images containing upstream k8s, and kind create cluster without any options will use one of these images. Currently these are at https://hub.docker.com/r/kindest/node until the wg-k8s-infra has a solution for subprojects to officially host images.

The line here seemed iffy since we're within the project but the kubernetes binaries we build ourselves are possibly debateable as "upstream" since while the sources are upstream, the actual binaries are currently built by us when we publish the image.

They do not contain any patches to Kubernetes.

kind can alternatively build and use an image from local Kubernetes sources, or from packages in apt, so I could see it being either.

Loading

@dankohn
Copy link
Contributor

@dankohn dankohn commented Jan 25, 2019

Loading

@BenTheElder
Copy link
Contributor Author

@BenTheElder BenTheElder commented Jan 25, 2019

Sounds good to me, Thanks!

Loading

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants