Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make favicons URLs relative #1

Closed
dankohn opened this issue Dec 16, 2018 · 3 comments
Closed

Make favicons URLs relative #1

dankohn opened this issue Dec 16, 2018 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@dankohn
Copy link
Contributor

dankohn commented Dec 16, 2018

Look at the URLs in view-source:https://landscapeapp.netlify.com/cncf/format=landscape

All of them should use relative URLs so that we can effectively QA changes at https://landscapeapp.netlify.com/cncf/format=landscape

@dankohn dankohn added the enhancement New feature or request label Dec 16, 2018
@AndreyKozlov1984
Copy link
Contributor

@dankohn please review! favicon is fetched properly, and relative urls are used everywhere.
for twitter and facebook meta tags I have not made changes, they do not affect the page rendering

@dankohn
Copy link
Contributor Author

dankohn commented Dec 18, 2018

@AndreyKozlov1984
Copy link
Contributor

Thanks, we do not need this file anymore

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants