Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial TAG Env website into Korean #398

Merged
merged 4 commits into from
May 6, 2024
Merged

Conversation

sysnet4admin
Copy link
Contributor

Hi tag-env-sustainability team,

Leo request to create ko website from en
So I changed contents for website which is related to ko.

Here is the link:
#325 (comment)

Copy link

netlify bot commented Apr 27, 2024

Deploy Preview for tag-env-sustainability ready!

Name Link
🔨 Latest commit 0db1ef5
🔍 Latest deploy log https://app.netlify.com/sites/tag-env-sustainability/deploys/66379a93c26160000892b627
😎 Deploy Preview https://deploy-preview-398--tag-env-sustainability.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Signed-off-by: Hoon Jo <pagaia@hotmail.com>
Signed-off-by: Hoon Jo <pagaia@hotmail.com>
@guidemetothemoon
Copy link
Contributor

@sysnet4admin if you check the build log for the failed quality checks you can see that it fails on the bunch of links that are invalid - if you navigate to those it returns 404. I think you would need to verify and update those links so that they're valid again🙌

@sysnet4admin
Copy link
Contributor Author

sysnet4admin commented Apr 29, 2024

@guidemetothemoon Oh...I am so sorry...I will fix it in a day.

@sysnet4admin
Copy link
Contributor Author

This page is not exist anymore. How could it handle? @guidemetothemoon May I get some advise?
https://community.cncf.io/events/details/cncf-hamburg-presents-cloud-native-sustainability-week-meetup-in-hamburg/

@guidemetothemoon
Copy link
Contributor

I'll check it out and help you with fixing those links @sysnet4admin !😊

@sysnet4admin
Copy link
Contributor Author

@guidemetothemoon Okay please let me know missing link :)
And then I will fix it at once ! (i.e. 404)

Signed-off-by: Kristina Devochko <kristina.devochko@tietoevry.com>
Signed-off-by: Kristina Devochko <kristina.devochko@tietoevry.com>
@guidemetothemoon
Copy link
Contributor

@sysnet4admin I fixed all the broken links to the valid ones and updated this PR accordingly. The build looks good now, and PR looks good to me so I'll go ahead and approve it😊
@leonardpahlke would you like to review it as well or shall I go ahead and merge it?

Copy link
Contributor

@guidemetothemoon guidemetothemoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thank you for your effort!😊

@leonardpahlke leonardpahlke merged commit bbdb46f into cncf:main May 6, 2024
6 checks passed
@sysnet4admin
Copy link
Contributor Author

@guidemetothemoon Oh Thank you for your kindness!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants