Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] Enhanc RowExpressionToDomainsVisitor to support BETWEEN AND expr push down #552

Closed
yukkit opened this issue Aug 20, 2022 · 5 comments
Assignees
Labels

Comments

@yukkit
Copy link
Contributor

yukkit commented Aug 20, 2022

Is your feature request related to a problem? Please describe.
Expr pushed down to tskv, the 'BETWEEN' expression is not supported yet.

Describe the solution you'd like

  • syntax
-- SELECT column1_name, column2_name, columnN_name FROM table_name WHERE column_name BETWEEN min_value AND max_value;

<between predicate> ::=
  <column name>  <between predicate part> 

<between predicate part> ::=
  [ NOT ] BETWEEN
      <literal value min>  AND <literal value max> 

eg.

SELECT * FROM employees
WHERE
  salary BETWEEN 7000 AND 9000;
  • suggest
    implement Expr::Between branch logic in pre_visit and post_visit of domain::RowExpressionToDomainsVisitor

Describe alternatives you've considered

Additional context

notes

only support column and literal value in between operator
ohter expr in between operator will translate to Domain::All (mean the operator match all records)

As part of #539 for predicate push down.

@guojidan
Copy link
Contributor

assign to me

@yukkit
Copy link
Contributor Author

yukkit commented Aug 31, 2023

@guojidan Note: This may have been simplified in the upstream logic to >= and <

@guojidan
Copy link
Contributor

@guojidan Note: This may have been simplified in the upstream logic to >= and <

ok,

@guojidan
Copy link
Contributor

guojidan commented Sep 1, 2023

@guojidan Note: This may have been simplified in the upstream logic to >= and <

ok,

because this have been simplified in the upstream,This issue does not exist.

@yukkit
Copy link
Contributor Author

yukkit commented Sep 1, 2023

thanks @guojidan , close

@yukkit yukkit closed this as completed Sep 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants