fix: fix parallel install from local directory #398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dead-horse
commented
Apr 21, 2022
| // use npm pack to ensure npmignore/gitignore/package.files work fine | ||
| const res = await cp.exec('npm pack', { cwd: filepath }); | ||
| const res = await cp.exec('npm pack', { cwd: tmpDir }); |
There was a problem hiding this comment.
npm pack 没有提供指定打包位置的方式，最保险就是把整体放到一个临时目录来打包，避免并发时的冲突。
There was a problem hiding this comment.
会慢一点，但是使用 local 的包应该不多，影响不大。
There was a problem hiding this comment.
https://docs.npmjs.com/cli/v8/commands/npm-pack#pack-destination npm8 有这个。下个月我们可以升级到这个版本。
There was a problem hiding this comment.
docs.npmjs.com/cli/v8/commands/npm-pack#pack-destination npm8 有这个。下个月我们可以升级到这个版本。
这个也看到了，等升级 npm 8 的时候我来蹭 PR 吧 hhhh
There was a problem hiding this comment.
想到一种更好的方法。可以用 npm-packlist 这个包获取到所有的文件，然后直接 cp 就好了，不需要 tgz 了。
dead-horse
force-pushed
the
fix-local-install
branch
from
ec7446b
to
568db72
Compare
|
我只发到 5.8.1，6.x 到时候升级到 npm8 重新实现？ |
vagusX
pushed a commit
to vagusX/npminstall
that referenced
this pull request
Aug 26, 2022
vagusX
added a commit
to vagusX/npminstall
that referenced
this pull request
Oct 17, 2022
gemwuu
pushed a commit
that referenced
this pull request
Oct 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.