fix: pick fix parallel install from local directory (#398) #421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vagusX
changed the title
fix parallel install from local directory (#398) (#412)![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -30,10 +30,13 @@ | |||
| async function localFolder(filepath, pkg, options) { | |||
| debug(`install ${pkg.name}@${pkg.rawSpec} from local folder ${filepath}`); | |||
| try { | |||
| // everytime copy to a different directory to avoid parallel install | |||
| const tmpDir = path.join(options.storeDir, '.tmp', randomUUID()); | |||
Check warning
Code scanning / CodeQL
Unsafe shell command constructed from library input
| // use npm pack to ensure npmignore/gitignore/package.files work fine | ||
| const res = await utils.exec('npm pack', { cwd: filepath }); | ||
| const res = await utils.exec(`npm pack --pack-destination ${tmpDir}`, { cwd: filepath }); |
Check warning
Code scanning / CodeQL
Unsafe shell command constructed from library input
|
This pull request introduces 2 alerts when merging c25134b into 1d7fbae - view on LGTM.com new alerts:
|
|
@gemwuu 版本发了回复上来。 |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: fix parallel install from local directory (fix: fix parallel install from local directory #398)
fix: parallel install from local directory
Co-authored-by: Yiyu He dead_horse@qq.com