Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loss statistic #15

Closed
dudanov opened this issue Dec 27, 2016 · 3 comments
Closed

Loss statistic #15

dudanov opened this issue Dec 27, 2016 · 3 comments

Comments

@dudanov
Copy link

dudanov commented Dec 27, 2016

Hi!
I have 2 questions:

  1. Why ping started with 100% loss?
  2. While ping in progress and screen is filled, loss value is jumping about one pixel cost (for example, 0~0.3%)
    I understand that this is not a bug, but rather a small unpleasant features of realization.
@cnlohr
Copy link
Member

cnlohr commented Dec 27, 2016

That is a good observation. I wasn't the person who added the ping loss feature, it looks like it just uses whatever's on-screen to do the calculation. Are you up for tweaking it to be a some other metric? Perhaps storing an array of tried vs given up? I don't believe I have a threshold now for giving up.

@dreua
Copy link
Member

dreua commented Mar 10, 2017

Here is my fix for issue 1: dreua@43f1ae1

Should I send a pull request?

I won't fix issue part 2 for my own use but I could give it a try if someone desperately needs it. ;)

@cnlohr
Copy link
Member

cnlohr commented Mar 10, 2017

Yes, please make a pull request. I tried thinking through it once and got confused.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants