Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rubocop 0.48 breaks CI #1548

Closed
coala-bot opened this issue Mar 26, 2017 · 5 comments
Closed

rubocop 0.48 breaks CI #1548

coala-bot opened this issue Mar 26, 2017 · 5 comments

Comments

@coala-bot
Copy link

@coala-bot coala-bot commented Mar 26, 2017

There was a new release yesterday at https://github.com/bbatsov/rubocop#cops which is probably causing build failure too.
upstream
importance/high

Opened via gitter by @yash-nisar

@jayvdb
Copy link
Member

@jayvdb jayvdb commented Mar 28, 2017

Looking at #1547, it seems pinning to 0.47.1 solves the problem?

@yash-nisar
Copy link
Member

@yash-nisar yash-nisar commented Mar 28, 2017

Yes, I've backported to the previous version. 🎉

yash-nisar added a commit to yash-nisar/coala-bears that referenced this issue Mar 28, 2017
Pin to verion 0.47.1 because tests were failing due to the
launch of a new release of rubocop 0.48.0

Closes coala#1548
@yash-nisar yash-nisar mentioned this issue Mar 28, 2017
2 of 2 tasks complete
yash-nisar added a commit to yash-nisar/coala-bears that referenced this issue Mar 28, 2017
Pin to verion 0.47.1 because tests were failing due to the
launch of a new release of rubocop 0.48.0

Fixes coala#1548
yash-nisar added a commit to yash-nisar/coala-bears that referenced this issue Mar 28, 2017
Pin to verion 0.47.1 because tests were failing due to the
launch of a new release of rubocop 0.48.0

Fixes coala#1548
@rultor rultor closed this in #1555 Mar 29, 2017
@jayvdb
Copy link
Member

@jayvdb jayvdb commented Apr 20, 2017

Still needs investigation to be able to upgrade to 0.48 or beyond.

@jayvdb jayvdb reopened this Apr 20, 2017
@jayvdb jayvdb modified the milestones: 0.11, 0.10.2 Apr 20, 2017
jayvdb added a commit to jayvdb/coala-bears that referenced this issue Apr 20, 2017
Pin to verion 0.47.1 because tests were failing due to the
launch of a new release of rubocop 0.48.0

Fixes coala#1548
jayvdb added a commit to jayvdb/coala-bears that referenced this issue Apr 20, 2017
Pin to verion 0.47.1 because tests were failing due to the
launch of a new release of rubocop 0.48.0

Fixes coala#1548
jayvdb added a commit to jayvdb/coala-bears that referenced this issue Apr 20, 2017
Pin to verion 0.47.1 because tests were failing due to the
launch of a new release of rubocop 0.48.0

Fixes coala#1548
@jayvdb jayvdb changed the title RubocopBear fails rubocop 0.48 breaks CI Apr 21, 2017
@jayvdb jayvdb modified the milestones: 0.11, 0.10.2, 0.12 Apr 25, 2017
jayvdb added a commit to jayvdb/coala-bears that referenced this issue Apr 28, 2017
Pin to verion 0.47.1 because tests were failing due to the
launch of a new release of rubocop 0.48.0

Fixes coala#1548
@jayvdb
Copy link
Member

@jayvdb jayvdb commented Jun 26, 2017

Latest release is 0.49.1

yash-nisar added a commit to yash-nisar/coala-bears that referenced this issue Jul 5, 2017
rubocop-hq/rubocop#4226 indicates that `--stdin`
takes filename as an argument which was incorporated. Also, the tests
were enhanced that involved the bear to be run on files with the `.rb`
(ruby) extension because initially the bear was run on the generated
temporary files that was the cause of error.

Fixes coala#1548
yash-nisar added a commit to yash-nisar/coala-bears that referenced this issue Jul 5, 2017
rubocop-hq/rubocop#4226 indicates that `--stdin`
takes filename as an argument which was incorporated. Also, the tests
were enhanced that involved the bear to be run on files with the `.rb`
(ruby) extension because initially the bear was run on the generated
temporary files that was the cause of error.

Fixes coala#1548
@yash-nisar yash-nisar mentioned this issue Jul 5, 2017
2 of 2 tasks complete
yash-nisar added a commit to yash-nisar/coala-bears that referenced this issue Jul 5, 2017
rubocop-hq/rubocop#4226 indicates that `--stdin`
takes filename as an argument which was incorporated. Also, the tests
were enhanced that involved the bear to be run on files with the `.rb`
(ruby) extension because initially the bear was run on the generated
temporary files that was the cause of error.

Fixes coala#1548
yash-nisar added a commit to yash-nisar/coala-bears that referenced this issue Jul 6, 2017
rubocop-hq/rubocop#4226 indicates that `--stdin`
takes filename as an argument which was incorporated. A part of the
fixing was to improve the tests that involved the bear to be run on
files with the `.rb`(ruby) extension because initially the bear was
run on the generated temporary files that was the cause of error.

Fixes coala#1548
yash-nisar added a commit to yash-nisar/coala-bears that referenced this issue Jul 6, 2017
rubocop-hq/rubocop#4226 indicates that `--stdin`
takes filename as an argument which was incorporated. A part of the
fixing was to improve the tests that involved the bear to be run on
files with the `.rb`(ruby) extension because initially the bear was
run on the generated temporary files that was the cause of error.

Fixes coala#1548
yash-nisar added a commit to yash-nisar/coala-bears that referenced this issue Jul 6, 2017
rubocop-hq/rubocop#4226 indicates that `--stdin`
takes filename as an argument which was incorporated. A part of the
fixing was to improve the tests that involved the bear to be run on
files with the `.rb`(ruby) extension because initially the bear was
run on the generated temporary files that was the cause of error.

Fixes coala#1548
yash-nisar added a commit to yash-nisar/coala-bears that referenced this issue Jul 6, 2017
rubocop-hq/rubocop#4226 indicates that `--stdin`
takes filename as an argument which was incorporated. A part of the
fixing was to improve the tests that involved the bear to be run on
files with the `.rb`(ruby) extension because initially the bear was
run on the generated temporary files that was the cause of error.

Fixes coala#1548
yash-nisar added a commit to yash-nisar/coala-bears that referenced this issue Jul 6, 2017
rubocop-hq/rubocop#4226 indicates that `--stdin`
takes filename as an argument which was incorporated. A part of the
fixing was to improve the tests that involved the bear to be run on
files with the `.rb`(ruby) extension because initially the bear was
run on the generated temporary files that was the cause of error.

Fixes coala#1548
@rultor rultor closed this in #1890 Jul 6, 2017
gosom pushed a commit to gosom/coala-bears that referenced this issue Jul 15, 2017
Pin to verion 0.47.1 because tests were failing due to the
launch of a new release of rubocop 0.48.0

Fixes coala#1548
gosom pushed a commit to gosom/coala-bears that referenced this issue Jul 15, 2017
rubocop-hq/rubocop#4226 indicates that `--stdin`
takes filename as an argument which was incorporated. A part of the
fixing was to improve the tests that involved the bear to be run on
files with the `.rb`(ruby) extension because initially the bear was
run on the generated temporary files that was the cause of error.

Fixes coala#1548
umeshksingla added a commit to umeshksingla/coala-bears that referenced this issue Sep 2, 2017
rubocop-hq/rubocop#4226 indicates that `--stdin`
takes filename as an argument which was incorporated. A part of the
fixing was to improve the tests that involved the bear to be run on
files with the `.rb`(ruby) extension because initially the bear was
run on the generated temporary files that was the cause of error.

Fixes coala#1548
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked pull requests

Successfully merging a pull request may close this issue.

4 participants
You can’t perform that action at this time.