Skip to content

Commit

Permalink
RuboCopBear.py: Pin to version 0.47.1
Browse files Browse the repository at this point in the history
Pin to verion 0.47.1 because tests were failing due to the
launch of a new release of rubocop 0.48.0

Closes coala#1548
  • Loading branch information
yash-nisar committed Mar 28, 2017
1 parent 63d31e1 commit 908c074
Show file tree
Hide file tree
Showing 4 changed files with 18 additions and 9 deletions.
14 changes: 11 additions & 3 deletions .ci/Gemfile.jinja2
Original file line number Diff line number Diff line change
@@ -1,5 +1,13 @@
source 'https://rubygems.org'
ruby '2.2.2'

{% for gem in gems %}gem "{{gem.name + '"' if gem.required == '' else gem.name + '", require: false'}}
{% endfor %}
{% for gem in gems %}
{%- if gem.version != '' and gem.required != '' %}
gem "{{ gem.name + '", "' + gem.version + '", require: false' }}
{%- elif gem.version == '' and gem.required == '' %}
gem "{{ gem.name + '"' }}
{%- elif gem.version != '' and gem.required == '' %}
gem "{{ gem.name + '", "' + gem.version + '"' }}
{%- else %}
gem "{{ gem.name + '", require: false' }}
{%- endif %}
{%- endfor %}
5 changes: 3 additions & 2 deletions .ci/generate_bear_requirements.py
Original file line number Diff line number Diff line change
Expand Up @@ -125,8 +125,9 @@ def write_gem_requirements(requirements):

for requirement in requirements:
gem_dependencies.append(
{'name' : requirement.package,
'required' : requirement.require})
{'name': requirement.package,
'version': requirement.version,
'required': requirement.require})

gemfile_string = template.render(
gems=gem_dependencies
Expand Down
6 changes: 3 additions & 3 deletions Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,8 @@ source 'https://rubygems.org'
ruby '2.2.2'

gem "csvlint"
gem "puppet-lint"
gem "puppet-lint", "2"
gem "reek"
gem "rubocop"
gem "rubocop", "0.47.1"
gem "scss_lint", require: false
gem "sqlint"
gem "sqlint"
2 changes: 1 addition & 1 deletion bears/ruby/RuboCopBear.py
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ class RuboCopBear:
"""

LANGUAGES = {'Ruby'}
REQUIREMENTS = {GemRequirement('rubocop'),
REQUIREMENTS = {GemRequirement('rubocop', '0.47.1'),
PipRequirement('pyyaml', '3.12')}
AUTHORS = {'The coala developers'}
AUTHORS_EMAILS = {'coala-devel@googlegroups.com'}
Expand Down

0 comments on commit 908c074

Please sign in to comment.