-
Notifications
You must be signed in to change notification settings - Fork 580
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bears: Add puppet lint bear [WIP] #238
Conversation
By analyzing the blame information on this pull request, we identified @AbdealiJK and @mr-karan to be potential reviewers |
def run(self, filename, file, puppet_cli_options: str=""): | ||
''' | ||
Checks the code with puppet-lint`. This will run puppet-lint | ||
over all puppet files seperately. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sudheesh001 Shouldn't we mention about puppet_cli_options
in docstrings?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a WIP, I will be doing this once the functionality is up, i've mentioned the problem i am facing on gitter
any progress? Need help? |
could you please run |
@sudheesh001 you still here? its been 22 days since your last answer here, making sure you are okay :) |
@Adrianzatreanu time to take over? |
none, got 2 exams in the following 2 days and a homework for wednesday, sorry. |
@Adrianzatreanu how about now? :P |
this needs to be restarted, as its with the old linter API, ill take it if nobody does and if i have time :) however, its a cool bear so maybe a newcomer would want to take over it :) |
Because this has been inactive for a while now I've taken this in at #747 |
Fixes #46