Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bears: Add puppet lint bear [WIP] #238

Closed
wants to merge 1 commit into from

Conversation

sudheesh001
Copy link
Member

Fixes #46

@mention-bot
Copy link

By analyzing the blame information on this pull request, we identified @AbdealiJK and @mr-karan to be potential reviewers

def run(self, filename, file, puppet_cli_options: str=""):
'''
Checks the code with puppet-lint`. This will run puppet-lint
over all puppet files seperately.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sudheesh001 Shouldn't we mention about puppet_cli_options in docstrings?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a WIP, I will be doing this once the functionality is up, i've mentioned the problem i am facing on gitter

@sils
Copy link
Member

sils commented Mar 21, 2016

any progress? Need help?

@Adrianzatreanu
Copy link
Contributor

could you please run coala over your code? and a rebase :) that should fix it

@Adrianzatreanu
Copy link
Contributor

@sudheesh001 you still here? its been 22 days since your last answer here, making sure you are okay :)

@sils sils modified the milestones: 0.1, Make Bears Great Apr 24, 2016
@sils
Copy link
Member

sils commented Apr 24, 2016

@Adrianzatreanu time to take over?

@Adrianzatreanu
Copy link
Contributor

none, got 2 exams in the following 2 days and a homework for wednesday, sorry.

@sils sils modified the milestones: 0.3, Make Bears Great May 6, 2016
@adtac
Copy link
Member

adtac commented Jul 22, 2016

got 2 exams in the following 2 days and a homework for wednesday, sorry.

@Adrianzatreanu how about now? :P

@Adrianzatreanu
Copy link
Contributor

this needs to be restarted, as its with the old linter API, ill take it if nobody does and if i have time :) however, its a cool bear so maybe a newcomer would want to take over it :)

@AbdealiLoKo
Copy link
Contributor

Because this has been inactive for a while now I've taken this in at #747

@AbdealiLoKo AbdealiLoKo closed this Sep 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

10 participants