Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was the newline here(at EOF) intentional?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
never; it is always bad on unix, except in a test file to show how bad it is.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Emacs always adds a newline at the end of the file and always clears up trailing whitespaces. Is adding a newline at the end of the file is bad ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
emacs is doing the right thing, assuming you are the author of that file.
It is distracting to add an EOL at EOF in a patch which isnt about that.
So, check your diff before you PR, and undo this emacs fixup unless you are modifying the last line of the file.
Ideally we create a bear to require it (coala/coala-bears#815), and then fix all the EOL problems at once. Until then, ignore any missing EOLs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Abhisek- Or you could add another commit fixing just that (although I'm leaning towards a end-of-line bear too). The idea is that each commit should be about one thing and just that one thing. Makes it much easier later on when you go through your commits.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh wait, this is merged lol
Guess we'll go with the bear thing now :D
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah..that was a mistake. I'll keep that in mind.