Skip to content
This repository has been archived by the owner on Apr 6, 2023. It is now read-only.

Please release VS2015 support #112

Closed
forderud opened this issue Jul 26, 2015 · 15 comments
Closed

Please release VS2015 support #112

forderud opened this issue Jul 26, 2015 · 15 comments

Comments

@forderud
Copy link

The latest publicly available (beta) version of CoApp PowerShell seem to be 1.23.521.0. This version does not support the "v140" pivot required for VS2015 support. Attempting to author a native VS2015 NuGet package exits with the following error: 'Write-NuGetPackage : Unmatched configuration choice 'v140''

Support for VS2015 was merged in September 2014 (#89), so this appears to be a question of releasing what is already implemented.

@igagis
Copy link

igagis commented Aug 7, 2015

any plans to release this?

@igagis
Copy link

igagis commented Aug 8, 2015

I emailed to @fearthecowboy about the issue, let's see if he could help

@jmecosta
Copy link

jmecosta commented Sep 7, 2015

you can define the pivots while release is not done.

configurations 
{
                      // This node contains custom pivot information.

                      Toolset 
                      {
                                                   key : "PlatformToolset"; // this is CoApp pre-defined key
                                                   choices: { v140, v120, v110, v100 };
                      };
}

@fearthecowboy
Copy link
Member

I've finally been given time between projects, I'm working on this today.

@forderud
Copy link
Author

Any progress on fixing this issue?

@NiViktor
Copy link

NiViktor commented Oct 2, 2015

I am also running into this issue.
Any update on when the VS 2015 support will be available?
Thanks!

@23W
Copy link

23W commented Oct 5, 2015

When update come out ?

@forderud
Copy link
Author

Any progress on fixing this issue?

@rchom
Copy link

rchom commented Dec 23, 2015

@jmecosta Where does the "configurations { ... } " workaround go?

@jmecosta
Copy link

Before the nuget section

@zabulus
Copy link

zabulus commented Jan 22, 2016

workaround works bad if I use v140 and v140_xp projects in my solution.
for <v140 .targets files had next condition, which matches both v110 and v110_xp:

 ( $(PlatformToolset.ToLower().IndexOf('v110')) &gt; -1

If I use workaround new .targets file contains:

'$(PlatformToolset.ToLower())' == 'v140'

Which unacceptable for my projects. Any thoughts?

@jmecosta
Copy link

You can always generate only the prop files with noclean option and the adjust the targets to your needs and generate the nugets yourself?

@zabulus
Copy link

zabulus commented Jan 23, 2016

I've workarounded my issue by following:

configurations {
    Toolset { 
        key : "PlatformToolset"; 
        choices: { v140 };  
        // Explicitly Not including pivot variants:  "WindowsKernelModeDriver8.0", "WindowsApplicationForDrivers8.0", "WindowsUserModeDriver8.0" 

        // We're normalizing out the concept of the v140 platform -- Overloading the $(PlatformToolset) variable for additional pivots was a dumb idea.
        v140.condition = "( $(PlatformToolset.ToLower().IndexOf('v140')) > -1 Or '$(PlatformToolset.ToLower())' == 'windowskernelmodedriver8.0' Or '$(PlatformToolset.ToLower())' == 'windowsapplicationfordrivers8.0' Or '$(PlatformToolset.ToLower())' == 'windowsusermodedriver8.0' )";
    };
}

CoApp seeks for the condition subsection and patches it's content right in a .targets file.

@lgxZJ
Copy link

lgxZJ commented Jun 16, 2017

hasn't fixed yet?

@forderud
Copy link
Author

forderud commented Aug 2, 2020

Closing, since this is unlikely to ever be fixed. My team have opted to instead use nuspec & targets files directly instead of coapp.

@forderud forderud closed this as completed Aug 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

9 participants