Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix/25 building via mvn clean install requires config server to run #4

Closed
wants to merge 8 commits into from
Closed

Bugfix/25 building via mvn clean install requires config server to run #4

wants to merge 8 commits into from

Conversation

BrunoSilvaATB
Copy link
Owner

@BrunoSilvaATB BrunoSilvaATB commented Aug 13, 2020 •
edited
Loading

Now CoatRack doesn't need a config server to run
closes coatrack#25

@BrunoSilvaATB BrunoSilvaATB self-assigned this Aug 13, 2020
@BrunoSilvaATB
Copy link
Owner Author

Now both application-test.yml and the bootstrap.properties are cleaned up

@BrunoSilvaATB
Copy link
Owner Author

BrunoSilvaATB commented Nov 11, 2020 •
edited
Loading

Update master, and test this bugfix with the script.
Convert script as it is in linux, to windows

@BrunoSilvaATB
Copy link
Owner Author

The 2 actions taken here were:

  • Suggestions Applied (created a build script for windows systems)
  • The branch was updated with the current master

The build tested and working:
image

@BrunoSilvaATB BrunoSilvaATB force-pushed the bugfix/25-Building-via-mvn-clean-install-requires-config-server-to-run branch from 7c7b7e3 to 9fe5848 Compare November 23, 2020 13:30
@BrunoSilvaATB
Copy link
Owner Author

Branch reverted (this branch was successfully reverted to the state before merging with master)

@BrunoSilvaATB
Copy link
Owner Author

This branch is updated with the latest master version.
This branch still needs to be tested after the bugfix for the ResourceServerProperties is merged

@BrunoSilvaATB @gr-hovest-atb
- CoatRack works without Config Server
6d75976 
- Config server fixed
- POM fixed from a possible mistake (The access of Maven to the resources, was configured to include and exclude the same files)
@BrunoSilvaATB @gr-hovest-atb
- pom.xml optimized
eda4afa
@BrunoSilvaATB @gr-hovest-atb
- Added bootstrap.properties and application-test.yml to the test/res…
7165037 
…ources

- Excluded directory rest/resources for the license header plugin
- Optimized application-test.yml with code cleanup to have only the parameters that matter to run the tests
@BrunoSilvaATB @gr-hovest-atb
- config server pom.xml changed
4735ea7 
- Excluded src/test/resources of the license header update goal
@BrunoSilvaATB @gr-hovest-atb
- Cleanup of application-test.yml and bootstrap.properties
45729b3 
- bookKeeping contact changed
@BrunoSilvaATB @gr-hovest-atb
- Parameters of application-test.yml and bootstrap.properties changed…
7ca7dd0 
… to sample data
@BrunoSilvaATB @gr-hovest-atb
Created script for windows systems of the build script (cmd file)
750f3b0
@BrunoSilvaATB @gr-hovest-atb
- build.cmd updated
1fe2cc5 
- Added run script for windows
@gr-hovest-atb gr-hovest-atb force-pushed the bugfix/25-Building-via-mvn-clean-install-requires-config-server-to-run branch from 92d46c3 to 1fe2cc5 Compare February 24, 2021 12:45
@BrunoSilvaATB
Copy link
Owner Author

@gr-hovest-atb as now we are removing the config server, is this PR still important?
As the objective was to be able to run CoatRack without config server

@BrunoSilvaATB
Copy link
Owner Author

reminder: Test running master branch of CoatRack without internet connection/ spring boot connection to master, and if this works without config server then close this PR

@gr-hovest-atb
Copy link
Collaborator

I did a test of the current master and it seems like this issue was implicitly solved by coatrack#158, which removes the "runtime config server dependency" from admin

@BrunoSilvaATB
Copy link
Owner Author

Based on the testing from @gr-hovest-atb (check comment above), this issue is fixed

@BrunoSilvaATB BrunoSilvaATB deleted the bugfix/25-Building-via-mvn-clean-install-requires-config-server-to-run branch December 9, 2021 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gr-hovest-atb gr-hovest-atb gr-hovest-atb left review comments

Assignees

@BrunoSilvaATB BrunoSilvaATB

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@BrunoSilvaATB @gr-hovest-atb