Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't see "Keep common parameter names" checkbox #30

Open
timothydmorton opened this issue Jul 4, 2019 · 4 comments
Open

Don't see "Keep common parameter names" checkbox #30

timothydmorton opened this issue Jul 4, 2019 · 4 comments
Labels
enhancement New feature or request

Comments

@timothydmorton
Copy link
Contributor

I'm running cobaya-cosmo-generator and I don't see the option for "Keep common parameter names" as is described in the documentation. Has this feature been discontinued? I've installed tag v1.2.1 from the repo and am running on Mac OS.

Screenshot:
Screenshot 2019-07-04 13 30 55

@JesusTorrado
Copy link
Contributor

JesusTorrado commented Jul 5, 2019

Hi @timothydmorton, and thanks for the issue report!

It has, I am afraid: some parameters do not map one-to-one between CAMB and CLASS (especially those about the neutrino sector), so, since it would not be complete (as in CLASS and CAMB would not be completely swappable even using common paramters), I removed it. it is still used internally e.g. to match CLASS-specific parameter names to the Planck covariance matrices.

My intention is to restore as much as possible of that functionality at some point in the future, so I'll leave this issue open as an enhancement, and I'll update the picture in the docs to remove the checkbox for the upcoming 2.0 (in 1 to 2 weeks).

@JesusTorrado JesusTorrado added the enhancement New feature or request label Jul 5, 2019
@timothydmorton
Copy link
Contributor Author

Sounds great! I'd certainly be happy to help contribute to re-implementing this, as I do like the idea. I'll keep an eye out for 2.0.

I just started playing around with using cobaya and I'm very impressed with it; nice work! I have another suggestion for the docs, which I'll make in a new issue.

@JesusTorrado
Copy link
Contributor

Good! I take note to keep you in the loop when I revisit the issue then (maybe by dropping some thought here in this issue).

Thanks for the nice words! Looking forward to your feedback/suggestions!

@JesusTorrado
Copy link
Contributor

I was not able to add it to 2.0, sorry (waiting for a CLASS update that has not yet arrived).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants