Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image refresh for fedora-coreos #305

Merged
merged 2 commits into from
Dec 16, 2019
Merged

Image refresh for fedora-coreos #305

merged 2 commits into from
Dec 16, 2019

Conversation

cockpituous
Copy link
Contributor

@cockpituous cockpituous commented Dec 5, 2019

Image refresh for fedora-coreos

@cockpituous cockpituous added the bot label Dec 5, 2019
@cockpituous cockpituous changed the title Image refresh for fedora-coreos WIP: centosci-tasks-rfr8l: [no-test] Image refresh for fedora-coreos Dec 5, 2019
@cockpituous
Copy link
Contributor Author

image-refresh in progress on centosci-tasks-rfr8l.
Log: https://logs-https-cockpit.apps.ci.centos.org/logs/image-refresh-305-20191205-073333/

@cockpituous
Copy link
Contributor Author

@cockpituous cockpituous changed the title WIP: centosci-tasks-rfr8l: [no-test] Image refresh for fedora-coreos Image refresh for fedora-coreos Dec 5, 2019
@martinpitt martinpitt self-assigned this Dec 5, 2019
@martinpitt
Copy link
Member

martinpitt commented Dec 5, 2019

I can reproduce the podman restart errors locally. Also interactively:

podman container runlabel RUN cockpit/ws  -- --no-tls
podman restart lucid_leakey

which does fail with

Error: container '2e66874cc981e5f32b6cbdcfa6be8570b75f81df0feeba65eca951fad3b8e2b6' already exists: OCI runtime error

This looks very close to https://discussion.fedoraproject.org/t/toolbox-not-working-again/12744 (thanks @garrett for pointing it out this morning) . I reported it to https://bugzilla.redhat.com/show_bug.cgi?id=1780161

Cockpituous and others added 2 commits December 11, 2019 10:28
Stop and start the container instead, and check if it was previously
running with --no-tls.

See https://bugzilla.redhat.com/show_bug.cgi?id=1780161 for details.
@martinpitt
Copy link
Member

There is a fix upstream now for the podman restart regression, but it apparently still takes a while until that lands. I added a workaround for now.

@martinpitt
Copy link
Member

network teams are still broken, I can reproduce locally.

@martinpitt
Copy link
Member

I sent cockpit-project/cockpit#13276 to skip the team tests. NetworkManager-team fell off the FCOS image.

@martinpitt
Copy link
Member

testMetrics failure, but that's most probably a flake.

@martinpitt
Copy link
Member

testMetrics keeps failing, meh.

@croissanne
Copy link
Contributor

@martinpitt it seems that whatever is generating the network traffic isn't doing so screenshot

@martinpitt
Copy link
Member

I finally went back to this. The simple reason is that netcat isn't available on this image any more, it apparently fell out due to some dependency changes between F30 and 31.

@martinpitt
Copy link
Member

I sent cockpit-project/cockpit#13296 to avoid netcat in the metrics test.

martinpitt added a commit to martinpitt/cockpit that referenced this pull request Dec 16, 2019
With the update to Fedora 31, current fedora-coreos image lost netcat;
see <cockpit-project/bots#305>.

socat is available everywhere, so change the test case to use that
instead of nc. As the current fedora-coreos image does not yet have
socat, disable the network traffic test on fedora-coreos until the above
PR lands.

Closes cockpit-project#13296
martinpitt added a commit to cockpit-project/cockpit that referenced this pull request Dec 16, 2019
With the update to Fedora 31, current fedora-coreos image lost netcat;
see <cockpit-project/bots#305>.

socat is available everywhere, so change the test case to use that
instead of nc. As the current fedora-coreos image does not yet have
socat, disable the network traffic test on fedora-coreos until the above
PR lands.

Closes #13296
@martinpitt martinpitt merged commit fcfd5aa into cockpit-project:master Dec 16, 2019
martinpitt pushed a commit that referenced this pull request Dec 16, 2019
martinpitt added a commit to martinpitt/cockpit that referenced this pull request Dec 16, 2019
Now that cockpit-project/bots#305 landed, our
fedora-coreos image has socat installed, so we can re-enable the network
load test in check-metrics (temporarily disabled in commit f3c331c).

Also adjust the comment in check-connection, as the reason for skipping
that is not the missing socat.

Closes cockpit-project#13302
marusak pushed a commit to cockpit-project/cockpit that referenced this pull request Dec 17, 2019
Now that cockpit-project/bots#305 landed, our
fedora-coreos image has socat installed, so we can re-enable the network
load test in check-metrics (temporarily disabled in commit f3c331c).

Also adjust the comment in check-connection, as the reason for skipping
that is not the missing socat.

Closes #13302
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants