Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Skip NetworkManager-team tests on fedora-coreos #13276

Merged
merged 1 commit into from
Dec 11, 2019
Merged

test: Skip NetworkManager-team tests on fedora-coreos #13276

merged 1 commit into from
Dec 11, 2019

Conversation

martinpitt
Copy link
Member

The NetworkManager-team package is not present any more in current
Fedora CoreOS images.

@martinpitt
test: Skip NetworkManager-team tests on fedora-coreos
f385607 
The NetworkManager-team package is not present any more in current
Fedora CoreOS images.
@martinpitt martinpitt added the no-test For doc/workflow changes, or experiments which don't need a full CI run, label Dec 11, 2019
@cockpituous cockpituous mentioned this pull request Dec 11, 2019
Merged
3 tasks
@martinpitt
Copy link
Member Author

The image refresh on cockpit-project/bots#305 fails on this.

@martinpitt martinpitt mentioned this pull request Dec 11, 2019
Closed
@martinpitt
Copy link
Member Author

@marusak: I filed coreos/fedora-coreos-config#253

marusak
marusak approved these changes Dec 11, 2019
View reviewed changes
Copy link
Member

@marusak marusak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
I wanted to ask you to add the issue url into the code so it is findable, but seems that it is never gonna get back, which is then of course fine.

@martinpitt
Copy link
Member Author

So the change is that rpm-ostree install now does not install Recommends any more (by default, at least). So we still need to report that regression, or accept it if it was deliberate.

@martinpitt martinpitt merged commit 9e2735b into cockpit-project:master Dec 11, 2019
@martinpitt martinpitt deleted the fcos-skip-team branch December 11, 2019 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marusak marusak marusak approved these changes

Assignees
No one assigned
Labels
no-test For doc/workflow changes, or experiments which don't need a full CI run,
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@martinpitt @marusak