Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent assigning already taken ports to containers #283

Closed
andreasn opened this issue Mar 18, 2014 · 4 comments
Closed

Prevent assigning already taken ports to containers #283

andreasn opened this issue Mar 18, 2014 · 4 comments
Labels
enhancement good-first-issue Appropriate for new contributors needsdesign
Milestone

Comments

@andreasn
Copy link
Contributor

Right now it's fairly easy to by mistake assign a port already used by another container to a new container. This results in the container just shutting down immediately.
We should check what ports are already in use and give a inline warning that the port is already used, but perhaps make it possible to go ahead anyway?

@andreasn andreasn added this to the Polish Docker milestone Mar 18, 2014
@stefwalter stefwalter added good-first-issue Appropriate for new contributors needsdesign labels Apr 20, 2015
@a2batic
Copy link

a2batic commented Oct 16, 2016

@andreasn @mvollmer @stefwalter @dperpeet. I would like to work upon the design. Can you elaborate on what all mockups are required here ?

@dperpeet
Copy link
Contributor

@andreasn @mvollmer @stefwalter @dperpeet. I would like to work upon the design. Can you elaborate on what all mockups are required here ?

This is an interesting one. I think before we need mockups here, we need some prior design steps: Some workflows / scoping. Should we detect just ports that docker is already using? All ports? Should the user be able to go ahead anyway? Maybe you need to try what happens right now when you try to use a port twice in the Cockpit/docker ui. Once those questions (and others?) are answered, we can think about where such a warning would be displayed in the ui. The run dialog is also currently being worked on, so mockups should probably wait until #4405 has been merged or it's ui is "stable".

@a2batic
Copy link

a2batic commented Oct 19, 2016

@dperpeet, till #4405 is being worked on, I will try to set up the issue on system.

@KKoukiou
Copy link
Contributor

See reasoning for closing here #4405 (comment)

marusak pushed a commit to marusak/cockpit that referenced this issue Jan 29, 2020
marusak pushed a commit to marusak/cockpit that referenced this issue Jan 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement good-first-issue Appropriate for new contributors needsdesign
Projects
None yet
Development

No branches or pull requests

7 participants