Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ovirt: call oVirt API actions synchronously #7672

Closed
mareklibra opened this issue Sep 14, 2017 · 0 comments
Closed

ovirt: call oVirt API actions synchronously #7672

mareklibra opened this issue Sep 14, 2017 · 0 comments
Assignees

Comments

@mareklibra
Copy link
Contributor

Call write actions (like host deactivation, shut down, run, etc) synchronously by setting async property within oVirt REST API requests.

By default, these API calls are asynchronous - response is sent before waiting on result (correlating) on server side. These calls fails just for eminent reasons.

Switching them to synchronous will give better experience to the user.
Significant increase of server load is not expected.

Followup for #7139

@mareklibra mareklibra changed the title ovirt: oVirt API actions synchronously ovirt: call oVirt API actions synchronously Sep 15, 2017
@mareklibra mareklibra self-assigned this Oct 20, 2017
mareklibra added a commit to mareklibra/cockpit that referenced this issue Oct 20, 2017
If possible, oVirt actions are called synchronously
from oVirt engine perspective.

It means, oVirt API HTTP call does not respond sooner
than the action is finished.
Please note, there is no full guarantee for that - bugs or
irregularities on oVirt side are still possible.

To avoid confusion - the client side (browser with cockpit-ovirt) is
still not blocked, the HTTP call is still performed asynchronously
thanks to Promises.

This change improves user experience in case of failures.

Closes cockpit-project#7672
martinpitt pushed a commit that referenced this issue Oct 23, 2017
If possible, oVirt actions are called synchronously
from oVirt engine perspective.

It means, oVirt API HTTP call does not respond sooner
than the action is finished.
Please note, there is no full guarantee for that - bugs or
irregularities on oVirt side are still possible.

To avoid confusion - the client side (browser with cockpit-ovirt) is
still not blocked, the HTTP call is still performed asynchronously
thanks to Promises.

This change improves user experience in case of failures.

Fixes #7672
Closes #7921
sabbaka pushed a commit to sabbaka/cockpit that referenced this issue Nov 15, 2017
If possible, oVirt actions are called synchronously
from oVirt engine perspective.

It means, oVirt API HTTP call does not respond sooner
than the action is finished.
Please note, there is no full guarantee for that - bugs or
irregularities on oVirt side are still possible.

To avoid confusion - the client side (browser with cockpit-ovirt) is
still not blocked, the HTTP call is still performed asynchronously
thanks to Promises.

This change improves user experience in case of failures.

Fixes cockpit-project#7672
Closes cockpit-project#7921
sabbaka pushed a commit to sabbaka/cockpit that referenced this issue Nov 27, 2017
If possible, oVirt actions are called synchronously
from oVirt engine perspective.

It means, oVirt API HTTP call does not respond sooner
than the action is finished.
Please note, there is no full guarantee for that - bugs or
irregularities on oVirt side are still possible.

To avoid confusion - the client side (browser with cockpit-ovirt) is
still not blocked, the HTTP call is still performed asynchronously
thanks to Promises.

This change improves user experience in case of failures.

Fixes cockpit-project#7672
Closes cockpit-project#7921
sabbaka pushed a commit to sabbaka/cockpit that referenced this issue Jan 12, 2018
If possible, oVirt actions are called synchronously
from oVirt engine perspective.

It means, oVirt API HTTP call does not respond sooner
than the action is finished.
Please note, there is no full guarantee for that - bugs or
irregularities on oVirt side are still possible.

To avoid confusion - the client side (browser with cockpit-ovirt) is
still not blocked, the HTTP call is still performed asynchronously
thanks to Promises.

This change improves user experience in case of failures.

Fixes cockpit-project#7672
Closes cockpit-project#7921
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant