tools: Skip slow tests on hppa in Debian #15223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hppa needs almost an hour to run the test-tls-certfile unit test. Skip slow tests on this architecture to avoid a build timeout. https://bugs.debian.org/981127
allisonkarlitskaya
approved these changes
Jan 27, 2021
| ifeq ($(shell dpkg-architecture -qDEB_BUILD_ARCH),riscv64) | ||
| # riscv is an emulated architecture for now, and too slow to run expensive unit tests | ||
| # hppa's threading is absurdly slow (#981127) | ||
| SLOW_ARCHES = $(filter $(shell dpkg-architecture -qDEB_BUILD_ARCH),riscv64 hppa) |
There was a problem hiding this comment.
squint
Fine with this change in theory, but I wonder if you could find a more readable way to express it...
I guess we don't have any kind of in verb here unfortunately :/
There was a problem hiding this comment.
Heh, yeah.. I modelled it after the other ifneq() bits we have (and previously had) in rules. Makefile syntax is so arcane that I usually resort to copy&paste of proven snippets than trying to invent something new :-/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hppa needs almost an hour to run the test-tls-certfile unit test. Skip
slow tests on this architecture to avoid a build timeout.
https://bugs.debian.org/981127