storaged: btrfs: allow btrfs subvolumes to be deleted #19872
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jelly
added
the
no-test
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
jelly
removed
the
no-test
jelly
force-pushed
the
btrfs-subvolume-deletion
branch
from
46eeaab
to
65ea293
Compare
jelly
commented
Jan 23, 2024
mvollmer
requested changes
Jan 23, 2024
mvollmer
requested changes
Jan 23, 2024
mvollmer
requested changes
Jan 23, 2024
mvollmer
requested changes
Jan 23, 2024
jelly
force-pushed
the
btrfs-subvolume-deletion
branch
from
65ea293
to
2d8eb8d
Compare
jelly
commented
Jan 25, 2024
jelly
force-pushed
the
btrfs-subvolume-deletion
branch
from
2d8eb8d
to
461d9e6
Compare
9 tasks
mvollmer
requested changes
Jan 29, 2024
jelly
force-pushed
the
btrfs-subvolume-deletion
branch
4 times, most recently
from
f01d3c2
to
40c0c90
Compare
Deletion is mostly similar to creation, except we allow a user to delete a parent and it's children from the UI unlike creation where we only allow a child to be created.
jelly
force-pushed
the
btrfs-subvolume-deletion
branch
from
40c0c90
to
a9afc52
Compare
cockpituous
reviewed
Jan 29, 2024
| let name; | ||
| if (block_stratis) { | ||
| name = block_stratis.Devnode; | ||
| } else if (block_btrfs && use.name) { |
There was a problem hiding this comment.
This added line is not executed by any test. Details
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Btrfs subvolume deletion
Allow created subvolumes to be deleted