storage: Add new integration layer between anaconda and cockpit storage #72

KKoukiou · 2023-11-30T08:16:44Z

Blocked on:

Add the attribute links to the device data anaconda#5422
storage: pass configured swap partition in the cockpit_mount_points cockpit-project/cockpit#19883
storage: adjust paddings for anaconda mode cockpit-project/cockpit#19876
https://issues.redhat.com/browse/INSTALLER-3880
LUKS spport in the new scenario - TODO katerina this PR
Rescanning deactivates LVM volumes - Marius introduced a workaround where c-storage handles inactive volumes
Btrfs full support Btrfs filesystem create support cockpit-project/cockpit#19880 storaged: btrfs: allow btrfs subvolumes to be deleted cockpit-project/cockpit#19872
Set "default_fsys_type" in "cockpit_anaconda" when starting Cockpit Storage.
Merge storage: Remember passphrases and export them to Anaconda cockpit-project/cockpit#19924

src/components/storage/MountPointMapping.jsx

src/components/storage/InstallationDestination.jsx

mvollmer · 2023-12-05T12:08:55Z

src/components/storage/MountPointMapping.jsx

@@ -58,6 +58,7 @@ import {
 import "./MountPointMapping.scss";

 const _ = cockpit.gettext;
+const cmpm = JSON.parse(window.localStorage.getItem("cockpit_mount_points"));


Cockpit is no longer exporting this information.

src/components/storage/ModifyStorage.jsx

mvollmer · 2023-12-12T14:37:56Z

@KKoukiou, could you rebase this? Thanks!

mvollmer · 2023-12-13T07:22:34Z

I made a version of this that works with cockpit-project/cockpit#19352: https://github.com/mvollmer/anaconda-webui/tree/cockpit-storage

cockpit-project/cockpit#19352 will not change incompatibly any more.

mvollmer · 2024-01-05T12:33:24Z

I have pushed my version here.

src/components/storage/MountPointMapping.jsx

rvykydal · 2024-01-25T13:17:12Z

I am seeing an issue: if I go to "Mount point assignment", then back and then to "Mount point assignment" again, required and recommended rows disappear. I hit it for example after creating one 10G ext4 partition (created in shell or via cockpit-storage). Rescan before going to the "Mount point assignment" makes the required/recommendend mount points to appear again.
I am not seeing the issue neither on main nor with these patches: #95
UPDATE:
I am seeing it on this patch in this PR stack: Break-line in the InstallationScenarioSelector component properties, I'll try to update tests for this issue -> #147

mvollmer · 2024-02-13T18:00:56Z

Nice!

I keep thinking that as a user, I would like to see the summary of what is being done immediately after "returning to installation", to double check whether Anaconda has correctly understood what I want to do. Now I have to fill out the account information before I can see the summary. Thus, the account stuff gets "in the way" of finishing the storage configuration.

KKoukiou · 2024-02-14T08:04:58Z

Nice!

I keep thinking that as a user, I would like to see the summary of what is being done immediately after "returning to installation", to double check whether Anaconda has correctly understood what I want to do. Now I have to fill out the account information before I can see the summary. Thus, the account stuff gets "in the way" of finishing the storage configuration.

I agree. @garrett can you give this some thought?

garrett · 2024-02-14T09:02:24Z

Sure, that makes sense. I thought Cockpit doesn't track the changes, however, which prevented us from showing this?

I wanted that too, but was told that Cockpit doesn't track the changes and Anaconda doesn't know about the changes either. So I don't know how we could even get this information or what it would be like.

Plus, at this stage, there is nothing to be done, as it was already done. Cockpit, via udisks, doesn't queue up changes, but acts on them immediately.

KKoukiou · 2024-02-14T09:31:30Z

Sure, that makes sense. I thought Cockpit doesn't track the changes, however, which prevented us from showing this?

I wanted that too, but was told that Cockpit doesn't track the changes and Anaconda doesn't know about the changes either. So I don't know how we could even get this information or what it would be like.

Plus, at this stage, there is nothing to be done, as it was already done. Cockpit, via udisks, doesn't queue up changes, but acts on them immediately.

All the information we present in the review page, (which partitions have which mount points etc) are already present when that dialog appears that allows us to exit storage mode.

We can add these information in that dialog if you like.

garrett · 2024-02-14T09:45:01Z

When I go to create a biosboot partition, it wants to give it all the available space. Why is space even configurable for this? Isn't it supposed to be 1 megabyte. Why does it have overwrite as an option too?

garrett · 2024-02-14T09:57:23Z

It says "Apply storage configuration and install". But didn't we already do storage configuration in Cockpit? Shouldn't it just be "Install" at this point in time?

garrett · 2024-02-14T09:59:20Z

Also, I went back and the configuration was lost, so I selected "mount point mapping" (to see what it'd say for the "X and install" button), which then won't let me proceed for some reason:

KKoukiou · 2024-02-14T14:01:48Z

Also, I went back and the configuration was lost, so I selected "mount point mapping" (to see what it'd say for the "X and install" button), which then won't let me proceed for some reason:

This is a 'bug' / 'feature'. you can remove the row with the trash icon the the next will be enabled. We dont want the user to submit a visibly incomplete form.

src/components/storage/CockpitStorageIntegration.jsx

rvykydal

Looks good to me, thank you.
Brave work!

This commit introduces a higher level of integration between Anaconda Web UI and Cockpit storage. When users perform advanced storage configuration, their storage settings will now seamlessly sync with Anaconda web UI. Specifically, selected mount points and configured LUKS devices will be automatically detected and utilized during installation, streamlining the process for users. This enhancement aims to improve the user experience and reduce manual configuration efforts during installation. Resolves: rhbz#2263971

Note: This is a temporary workaround which should be obsoleted and removed once https://issues.redhat.com/browse/INSTALLER-3898 is fixed.

…ks when configuring manually storage

…d storage" scenario

KKoukiou added the no-test label Nov 30, 2023

github-advanced-security bot found potential problems Nov 30, 2023

View reviewed changes

src/components/storage/MountPointMapping.jsx Fixed Show fixed Hide fixed

KKoukiou added the blocked label Nov 30, 2023

mvollmer reviewed Dec 5, 2023

View reviewed changes

src/components/storage/InstallationDestination.jsx Outdated Show resolved Hide resolved

mvollmer reviewed Dec 5, 2023

View reviewed changes

src/components/storage/ModifyStorage.jsx Outdated Show resolved Hide resolved

mvollmer mentioned this pull request Dec 5, 2023

storage: Anaconda mode cockpit-project/cockpit#19352

Merged

mvollmer force-pushed the cockpit-storage branch from f01f3f3 to d3e398d Compare January 5, 2024 12:32

mvollmer force-pushed the cockpit-storage branch from d3e398d to e421bf3 Compare January 5, 2024 12:43

KKoukiou force-pushed the cockpit-storage branch 3 times, most recently from 4a187e1 to 79d8d89 Compare January 12, 2024 15:29

KKoukiou force-pushed the cockpit-storage branch 5 times, most recently from c6f8b87 to 8a26fe7 Compare January 19, 2024 15:06

github-advanced-security bot found potential problems Jan 19, 2024

View reviewed changes

src/components/storage/MountPointMapping.jsx Fixed Show fixed Hide fixed

KKoukiou force-pushed the cockpit-storage branch 3 times, most recently from 2c4f311 to ba42dc5 Compare January 24, 2024 20:00

KKoukiou mentioned this pull request Jan 24, 2024

storage: pass configured swap partition in the cockpit_mount_points cockpit-project/cockpit#19883

Merged

rvykydal mentioned this pull request Jan 30, 2024

Prepare for the blivet-gui / cockpit-storage migration #146

Merged

KKoukiou force-pushed the cockpit-storage branch 3 times, most recently from 6f82b02 to 4326a56 Compare February 6, 2024 10:30

KKoukiou force-pushed the cockpit-storage branch from 5309469 to d14a189 Compare February 14, 2024 12:04

rvykydal reviewed Feb 14, 2024

View reviewed changes

src/components/storage/CockpitStorageIntegration.jsx Outdated Show resolved Hide resolved

rvykydal approved these changes Feb 14, 2024

View reviewed changes

KKoukiou force-pushed the cockpit-storage branch 7 times, most recently from 05c442e to edb0f47 Compare February 14, 2024 16:57

KKoukiou added 9 commits February 16, 2024 09:06

storage: read configuration objects cockpit from sessionStorage

b978717

storage: unlock luks devices with the passphrases we get from cockpit

fcbde4d

Note: This is a temporary workaround which should be obsoleted and removed once https://issues.redhat.com/browse/INSTALLER-3898 is fixed.

tests: add missing test packages into the boot.iso

76337c7

tests: download cockpit-storaged from custom COPR till release 311

33d3821

storage: check for existing biosboot partition in the validation chec…

9c1beeb

…ks when configuring manually storage

storage: try to unlock all devices that cockpit gives us passwords for

ac5279d

tests: adapt to cockpit changes on root btrfs volume

5d6a38f

review: change button label to plain "install" for the 'Use configure…

33dfc8e

…d storage" scenario

KKoukiou force-pushed the cockpit-storage branch from edb0f47 to 33dfc8e Compare February 16, 2024 08:08

KKoukiou merged commit ddd1dff into rhinstaller:main Feb 16, 2024
5 of 7 checks passed

KKoukiou deleted the cockpit-storage branch February 16, 2024 08:48

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

storage: Add new integration layer between anaconda and cockpit storage #72

storage: Add new integration layer between anaconda and cockpit storage #72

KKoukiou commented Nov 30, 2023 •

edited

mvollmer Dec 5, 2023

mvollmer commented Dec 12, 2023

mvollmer commented Dec 13, 2023

mvollmer commented Jan 5, 2024

rvykydal commented Jan 25, 2024 •

edited

mvollmer commented Feb 13, 2024

KKoukiou commented Feb 14, 2024

garrett commented Feb 14, 2024 •

edited

KKoukiou commented Feb 14, 2024

garrett commented Feb 14, 2024

garrett commented Feb 14, 2024

garrett commented Feb 14, 2024

KKoukiou commented Feb 14, 2024 •

edited

rvykydal left a comment

storage: Add new integration layer between anaconda and cockpit storage #72

storage: Add new integration layer between anaconda and cockpit storage #72

Conversation

KKoukiou commented Nov 30, 2023 • edited

mvollmer Dec 5, 2023

Choose a reason for hiding this comment

mvollmer commented Dec 12, 2023

mvollmer commented Dec 13, 2023

mvollmer commented Jan 5, 2024

rvykydal commented Jan 25, 2024 • edited

mvollmer commented Feb 13, 2024

KKoukiou commented Feb 14, 2024

garrett commented Feb 14, 2024 • edited

KKoukiou commented Feb 14, 2024

garrett commented Feb 14, 2024

garrett commented Feb 14, 2024

garrett commented Feb 14, 2024

KKoukiou commented Feb 14, 2024 • edited

rvykydal left a comment

Choose a reason for hiding this comment

KKoukiou commented Nov 30, 2023 •

edited

rvykydal commented Jan 25, 2024 •

edited

garrett commented Feb 14, 2024 •

edited

KKoukiou commented Feb 14, 2024 •

edited