storage: Remember passphrases and export them to Anaconda #19924
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Ah, yes, I forgot about this case. I was only looking for the Unlock() method... Thanks! |
mvollmer
force-pushed
the
storage-anaconda-password-export
branch
2 times, most recently
from
59b5340
to
1290a16
Compare
Yes, hmm, let's not hide all errors when exporting, I went too far with that. I don't want the page to crash when there is garbage in sessionStorage, but I think we should crash when there is a bug in the exporting code. |
mvollmer
force-pushed
the
storage-anaconda-password-export
branch
from
1290a16
to
1ecb7d8
Compare
Should be fixed. |
mvollmer
force-pushed
the
storage-anaconda-password-export
branch
from
1ecb7d8
to
396a7e4
Compare
I can't reproduce this, unfortunately. |
mvollmer
force-pushed
the
storage-anaconda-password-export
branch
from
99f6d96
to
e7eeeb1
Compare
mvollmer
force-pushed
the
storage-anaconda-password-export
branch
from
e7eeeb1
to
4e29016
Compare
mvollmer
force-pushed
the
storage-anaconda-password-export
branch
3 times, most recently
from
e6895fc
to
3fbe954
Compare
mvollmer
force-pushed
the
storage-anaconda-password-export
branch
from
3fbe954
to
54761d2
Compare
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
|
Oops, we need tests, forgot about that. |
martinpitt
dismissed
their stale review
Retracing veto, missed the special case
|
Ah, I missed that it skips the storing of passphrases in non-anaconda mode, this alleviates most of my concern. So I retract my veto. |
mvollmer
force-pushed
the
storage-anaconda-password-export
branch
3 times, most recently
from
8712a02
to
6cf61ca
Compare
mvollmer
force-pushed
the
storage-anaconda-password-export
branch
from
6cf61ca
to
bddb7d0
Compare
mvollmer
force-pushed
the
storage-anaconda-password-export
branch
from
bddb7d0
to
56676a4
Compare
mvollmer
force-pushed
the
storage-anaconda-password-export
branch
2 times, most recently
from
92bccde
to
21a588b
Compare
mvollmer
force-pushed
the
storage-anaconda-password-export
branch
from
21a588b
to
967456b
Compare
This also changes everything from localStorage to sessionStorage, for good measure.
mvollmer
force-pushed
the
storage-anaconda-password-export
branch
from
967456b
to
e482442
Compare
There was a problem hiding this comment.
As mentioned on matrix.
- Please merge this asap, tests are currently passing with this and my open cockpit-storage integration PR
- create a ticket in COCKPIT component in Jira to remove this code which will be blocked on https://issues.redhat.com/browse/INSTALLER-3898
- I already started working on https://issues.redhat.com/browse/INSTALLER-3898 and it looks very promising - even for this f40 release
Merging prematurely this - even though it's not final solution - will make our collaboration more seemless as we can develop on top of existing tests to at least not break the functionality
| } catch { | ||
| console.warn("Can't record passphrases"); |
There was a problem hiding this comment.
These 2 added lines are not executed by any test. Details
| remember_passphrase(block, passphrase); | ||
| } else if (passphrase_type == "stored") { | ||
| await crypto.Unlock("", {}); | ||
| } else if (passphrase_type == "clevis") { |
There was a problem hiding this comment.
This added line is not executed by any test. Details
No description provided.