shell: Allow specific dashboards to be default page #3317
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petervo
force-pushed
the
single-host-dashboards
branch
3 times, most recently
from
3712e59
to
7623808
Compare
|
Hmmm, although I agree with what this is trying to do, I think the nomenclature and options are confusing. In particular:
Needs more thought. |
petervo
force-pushed
the
single-host-dashboards
branch
2 times, most recently
from
5805411
to
b5f3fb4
Compare
Dashboards like the machine dashboard don't make much sense to display if there is only one machine allow those dashboards to opt out of displaying as the default cockpit landing page without preventing other dashboards from displaying as default even when there is only one machine.
petervo
force-pushed
the
single-host-dashboards
branch
from
b5f3fb4
to
cf27aea
Compare
|
Changed to a more generic wants field that the default dashboard can use to opt out. |
stefwalter
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a dashboard only communicates with a single host there is no reason to stop it from showing as the
default page, even when cockpit only has a single active machine.