Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ws: Actually exit when idle #3554

Closed
wants to merge 1 commit into from

Conversation

Projects
None yet
2 participants
@stefwalter
Copy link
Contributor

commented Jan 23, 2016

The logic to actually exit when cockpit-ws is idle had regressed
and it would no longer quit.

Add a test to cover the case.

@stefwalter stefwalter force-pushed the stefwalter:idle-exit branch from 2eeca44 to 0e5ec38 Jan 24, 2016

stefwalter added a commit to stefwalter/cockpit that referenced this pull request Jan 24, 2016

ws: Actually exit when idle
The logic to actually exit when cockpit-ws is idle had regressed
and it would no longer quit.

Add a test to cover the case.

Closes cockpit-project#3554

@stefwalter stefwalter added the priority label Jan 25, 2016

@dperpeet dperpeet self-assigned this Jan 25, 2016

}
/* Now wait for 3 seconds, and the auth should have said its idling */
flag = FALSE;
while (!flag && !idling)

This comment has been minimized.

Copy link
@dperpeet

dperpeet Jan 25, 2016

Member

why does flag have to be set and tested again here? If we're testing with a timeout, shouldn't we start it again explicitly?

This comment has been minimized.

Copy link
@stefwalter

stefwalter Jan 25, 2016

Author Contributor

So the second timeout can kick in.

@dperpeet dperpeet added needswork and removed needswork labels Jan 25, 2016

@stefwalter stefwalter force-pushed the stefwalter:idle-exit branch from 0e5ec38 to 51bdced Jan 25, 2016

stefwalter added a commit to stefwalter/cockpit that referenced this pull request Jan 25, 2016

ws: Actually exit when idle
The logic to actually exit when cockpit-ws is idle had regressed
and it would no longer quit.

Add a test to cover the case.

Closes cockpit-project#3554
@stefwalter

This comment has been minimized.

Copy link
Contributor Author

commented Jan 25, 2016

Added a second timeout.

@dperpeet

This comment has been minimized.

ws: Actually exit when idle
The logic to actually exit when cockpit-ws is idle had regressed
and it would no longer quit.

Add a test to cover the case.

Closes #3554

@stefwalter stefwalter force-pushed the stefwalter:idle-exit branch from 51bdced to 5398445 Jan 25, 2016

@stefwalter

This comment has been minimized.

Copy link
Contributor Author

commented Jan 25, 2016

Updated the docs.

@dperpeet dperpeet closed this in a4477d7 Jan 25, 2016

@stefwalter stefwalter deleted the stefwalter:idle-exit branch Feb 1, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.