ws: Actually exit when idle #3554
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
| /* Now wait for 3 seconds, and the auth should have said its idling */ | ||
| flag = FALSE; | ||
| while (!flag && !idling) |
There was a problem hiding this comment.
why does flag have to be set and tested again here? If we're testing with a timeout, shouldn't we start it again explicitly?
There was a problem hiding this comment.
So the second timeout can kick in.
|
Added a second timeout. |
|
Should we update the docs at the same time? https://github.com/cockpit-project/cockpit/blob/master/doc/man/cockpit-ws.xml#L95 |
The logic to actually exit when cockpit-ws is idle had regressed and it would no longer quit. Add a test to cover the case. Closes cockpit-project#3554
|
Updated the docs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The logic to actually exit when cockpit-ws is idle had regressed
and it would no longer quit.
Add a test to cover the case.