Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request to add PG::TRSerializationFailure handling to 6-1-stable #335

Closed
harelsafra opened this issue Jul 31, 2024 · 2 comments
Closed

Request to add PG::TRSerializationFailure handling to 6-1-stable #335

harelsafra opened this issue Jul 31, 2024 · 2 comments

Comments

@harelsafra
Copy link

harelsafra commented Jul 31, 2024

Hi,
We migrated to CRDB and are getting sporadic PG::TRSerializationFailure errors, currently using the PG driver.
We're using rails 6.1.7.3 and so need to use the 6.1 gem, and it looks like it doesn't catch and retry PG::TRSerializationFailure errors
https://github.com/cockroachdb/activerecord-cockroachdb-adapter/blob/6-1-stable/lib/active_record/connection_adapters/cockroachdb/transaction_manager.rb
While the master branch does have this handling

Can this functionality please be added to 6.1?
I tried to fork the repo and add this but I got a lot of failing test cases, even before I changed anything 😢

Thanks

@BuonOmo
Copy link
Collaborator

BuonOmo commented Aug 2, 2024

@harelsafra there are indeed failing tests around this (see #333). I'm working on it now. I don't feel safe backporting this knowing that there are some unresolved bugs.

@harelsafra
Copy link
Author

Thanks @BuonOmo , I'll follow #333

@BuonOmo BuonOmo closed this as completed Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants