Merge #108472 #108576

108472: roachtest: delete archaic jobs/mixed-version test r=dt a=adityamaru

This roachtest has dubious intentions. The expected logic on job cancellation and failure is specific to the job type. It is more useful to write job type specific unit tests rather than a roachtest to test these behaviours.

Fixes: #67587
Release note: None

108576: opt: fix index alteration recommendation for multiple invisible indexes r=rytaft a=rytaft

Fixes #108490

Release note (bug fix): Fixed a bug in the index recommendations provided in the `EXPLAIN` output where `ALTER INDEX ... VISIBLE` index recommendations may suggest making the wrong index visible when there are multiple invisible indexes in a table.

Co-authored-by: adityamaru <adityamaru@gmail.com>
Co-authored-by: Rebecca Taft <becca@cockroachlabs.com>

pkg/cmd/roachtest/tests/BUILD.bazel

@@ -100,7 +100,6 @@ go_library(
         "mixed_version_decl_schemachange_compat.go",
         "mixed_version_decommission.go",
         "mixed_version_job_compatibility_in_declarative_schema_changer.go",
-        "mixed_version_jobs.go",
         "mixed_version_schemachange.go",
         "multitenant.go",
         "multitenant_distsql.go",

pkg/cmd/roachtest/tests/registry.go

@@ -71,7 +71,6 @@ func RegisterTests(r registry.Registry) {
 	registerIndexes(r)
 	registerJasyncSQL(r)
 	registerJepsen(r)
-	registerJobsMixedVersions(r)
 	registerKV(r)
 	registerKVBench(r)
 	registerKVContention(r)