opt: fix index alteration recommendation for multiple invisible indexes #108576
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes cockroachdb#108490 Release note (bug fix): Fixed a bug in the index recommendations provided in the EXPLAIN output where ALTER INDEX ... VISIBLE index recommendations may suggest making the wrong index visible when there are multiple invisible indexes in a table.
rytaft
added
backport-22.2.x
|
This change is |
michae2
approved these changes
Aug 11, 2023
There was a problem hiding this comment.
Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @msirek)
|
TFTR! bors r+ |
|
Build succeeded: |
|
Encountered an error creating backports. Some common things that can go wrong:
You might need to create your backport manually using the backport tool. error creating merge commit from 507e594 to blathers/backport-release-22.2-108576: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict [] you may need to manually resolve merge conflicts with the backport tool. Backport to branch 22.2.x failed. See errors above. error creating merge commit from 507e594 to blathers/backport-release-23.1-108576: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict [] you may need to manually resolve merge conflicts with the backport tool. Backport to branch 23.1.x failed. See errors above. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
This was referenced Aug 11, 2023
Merged
mgartner
added a commit
to mgartner/cockroach
that referenced
this pull request
Sep 6, 2023
A bug was introduced in cockroachdb#108576 in code that compares index columns of an existing index and a hypothetical index. Prior to this commit, this logic only checked that the hypothetical index column was an inverted column (the last explicitly indexed column in an inverted index) before fetching the inverted source column ordinal for both the hypothetical and existing index column. When the existing index column was not an inverted column, and internal error would occur. This commit fixes the bug by checking that both the hypothetical and existing index columns are inverted columns before fetching the source column ordinals. There is no release note because this bug does not exist in any releases. Fixes cockroachdb#109974 Release note: None
craig bot
pushed a commit
that referenced
this pull request
Sep 6, 2023
110116: indexrec: fix internal error with inverted indexes r=mgartner a=mgartner A bug was introduced in #108576 in code that compares index columns of an existing index and a hypothetical index. Prior to this commit, this logic only checked that the hypothetical index column was an inverted column (the last explicitly indexed column in an inverted index) before fetching the inverted source column ordinal for both the hypothetical and existing index column. When the existing index column was not an inverted column, and internal error would occur. This commit fixes the bug by checking that both the hypothetical and existing index columns are inverted columns before fetching the source column ordinals. There is no release note because this bug does not exist in any releases. Fixes #109974 Release note: None Co-authored-by: Marcus Gartner <marcus@cockroachlabs.com>
blathers-crl bot
pushed a commit
that referenced
this pull request
Sep 6, 2023
A bug was introduced in #108576 in code that compares index columns of an existing index and a hypothetical index. Prior to this commit, this logic only checked that the hypothetical index column was an inverted column (the last explicitly indexed column in an inverted index) before fetching the inverted source column ordinal for both the hypothetical and existing index column. When the existing index column was not an inverted column, and internal error would occur. This commit fixes the bug by checking that both the hypothetical and existing index columns are inverted columns before fetching the source column ordinals. There is no release note because this bug does not exist in any releases. Fixes #109974 Release note: None
This was referenced Sep 6, 2023
blathers-crl bot
pushed a commit
that referenced
this pull request
Sep 6, 2023
A bug was introduced in #108576 in code that compares index columns of an existing index and a hypothetical index. Prior to this commit, this logic only checked that the hypothetical index column was an inverted column (the last explicitly indexed column in an inverted index) before fetching the inverted source column ordinal for both the hypothetical and existing index column. When the existing index column was not an inverted column, and internal error would occur. This commit fixes the bug by checking that both the hypothetical and existing index columns are inverted columns before fetching the source column ordinals. There is no release note because this bug does not exist in any releases. Fixes #109974 Release note: None
mgartner
added a commit
to mgartner/cockroach
that referenced
this pull request
Sep 6, 2023
A bug was introduced in cockroachdb#108576 in code that compares index columns of an existing index and a hypothetical index. Prior to this commit, this logic only checked that the hypothetical index column was an inverted column (the last explicitly indexed column in an inverted index) before fetching the inverted source column ordinal for both the hypothetical and existing index column. When the existing index column was not an inverted column, and internal error would occur. This commit fixes the bug by checking that both the hypothetical and existing index columns are inverted columns before fetching the source column ordinals. There is no release note because this bug does not exist in any releases. Fixes cockroachdb#109974 Release note: None
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #108490
Release note (bug fix): Fixed a bug in the index recommendations provided in the
EXPLAINoutput whereALTER INDEX ... VISIBLEindex recommendations may suggest making the wrong index visible when there are multiple invisible indexes in a table.