Skip to content

Commit

Permalink
rfc: mark partial index RFC as complete
Browse files Browse the repository at this point in the history
Release justification: This commit updates an RFC which is a
non-production code change.

Release note: None
  • Loading branch information
mgartner committed Aug 27, 2020
1 parent 3fd6e3b commit 3736fcf
Showing 1 changed file with 13 additions and 13 deletions.
26 changes: 13 additions & 13 deletions docs/RFCS/20200507_partial_indexes.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
- Feature Name: Partial Indexes
- Status: in-progress
- Status: completed
- Start Date: 2020-05-07
- Authors: mgartner
- RFC PR: [#48557](https://github.com/cockroachdb/cockroach/pull/48557)
Expand Down Expand Up @@ -400,29 +400,29 @@ disjunction on only one column, which a constraint _can_ represent.
Below is a list of the steps (PRs) to implement partial indexes, roughly
ordered.

- [ ] Add partial index predicate to internal index data structures, add parser
- [X] Add partial index predicate to internal index data structures, add parser
support for `WHERE <predicate>`, add a cluster flag for gating this
defaulted to "off"
- [ ] Add simple equality implication check to optimizer when generating index
- [X] Add simple equality implication check to optimizer when generating index
scans, in GenerateIndexScans.
- [ ] Same, for GenerateConstrainedScans.
- [ ] Add support for updating partial indexes on inserts.
- [ ] Add support for updating partial indexes on deletes.
- [ ] Add support for updating partial indexes on updates and upserts.
- [ ] Add support for backfilling partial indexes.
- [ ] Update the statistics builder to account for the selectivity of the partial index
- [X] Same, for GenerateConstrainedScans.
- [X] Add support for updating partial indexes on inserts.
- [X] Add support for updating partial indexes on deletes.
- [X] Add support for updating partial indexes on updates and upserts.
- [X] Add support for backfilling partial indexes.
- [X] Update the statistics builder to account for the selectivity of the partial index
predicate.
- [ ] Add more advanced implication logic for filter and predicate expressions.
- [X] Add more advanced implication logic for filter and predicate expressions.
- [ ] Add support in other index exploration rules:
- [ ] GenerateInvertedIndexScans
- [ ] GenerateZigZagJoin
- [ ] GenerateInvertedIndexZigZagJoin
- [ ] Add support for partitioned partial indexes
- [X] Add support for partitioned partial indexes
- [ ] Add support for using partial indexes in Lookup Joins
- [ ] Consider using partial indexes for auto-generated indexes used for foreign
keys.
- [ ] [Stretch goal] Add support for `ON CONFLICT WHERE [index_predicate] DO
...` for identifying conflict behavior for uniquer partial indexes.
- [X] Add support for `ON CONFLICT WHERE [index_predicate] DO ...` for identifying
conflict behavior for unique partial indexes.
- More info in the [Postgres
docs](https://www.postgresql.org/docs/9.5/sql-insert.html#SQL-ON-CONFLICT)
and [this blog
Expand Down

0 comments on commit 3736fcf

Please sign in to comment.