Skip to content

Commit

Permalink
sql: job SessionData OptimizerFKCascadesLimit not defaulting to optDr…
Browse files Browse the repository at this point in the history
…ivenFKCascadesClusterLimit

Fixes #101265

`SessionData` available to in the job context has a 0-value
`OptimizerFKCascadesLimit`.

This causes DELETE queries run by the job with an inbound on-delete-cascade FK
to fail with an error `cascades limit (0) reached`.

This change fixes this by populating OptimizerFKCascadesLimit in
`sql.NewFakeSessionData`.

Release note: None
  • Loading branch information
ecwall committed Apr 11, 2023
1 parent 44b3ad5 commit 4a52fbf
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion pkg/sql/schema_changer.go
Original file line number Diff line number Diff line change
Expand Up @@ -2567,7 +2567,8 @@ func NewFakeSessionData(sv *settings.Values) *sessiondata.SessionData {
Internal: true,
},
LocalOnlySessionData: sessiondatapb.LocalOnlySessionData{
DistSQLMode: sessiondatapb.DistSQLExecMode(DistSQLClusterExecMode.Get(sv)),
DistSQLMode: sessiondatapb.DistSQLExecMode(DistSQLClusterExecMode.Get(sv)),
OptimizerFKCascadesLimit: optDrivenFKCascadesClusterLimit.Get(sv),
},
SearchPath: sessiondata.DefaultSearchPathForUser(username.NodeUserName()),
SequenceState: sessiondata.NewSequenceState(),
Expand Down

0 comments on commit 4a52fbf

Please sign in to comment.