Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sql: job SessionData OptimizerFKCascadesLimit not defaulting to optDrivenFKCascadesClusterLimit #101265

Closed
ecwall opened this issue Apr 11, 2023 · 0 comments · Fixed by #101267
Closed

sql: job SessionData OptimizerFKCascadesLimit not defaulting to optDrivenFKCascadesClusterLimit #101265

ecwall opened this issue Apr 11, 2023 · 0 comments · Fixed by #101267
Assignees
@ecwall
Labels
C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)
Projects
SQL Sessions - Deprecated

Comments

@ecwall
Copy link
Contributor

ecwall commented Apr 11, 2023 •
edited by exalate-issue-sync bot

SessionData available to in the job context has a 0-value OptimizerFKCascadesLimit.

This causes DELETE queries run by the job with an inbound on-delete-cascade FK to fail with an error cascades limit (0) reached.

To fix this, OptimizerFKCascadesLimit must be populated in sql.NewFakeSessionData.

Jira issue: CRDB-26886

Epic CRDB-26101
@ecwall ecwall added C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions) labels Apr 11, 2023
@ecwall ecwall self-assigned this Apr 11, 2023
@ecwall ecwall added this to Triage in SQL Sessions - Deprecated via automation Apr 11, 2023
This was referenced Apr 11, 2023
Merged
Merged
craig bot pushed a commit that referenced this issue Apr 12, 2023
@ecwall
Merge #101267
e1e9281 
101267: sql: job SessionData OptimizerFKCascadesLimit not defaulting to optDrivenFKCascadesClusterLimit r=otan a=ecwall

Fixes #101265

`SessionData` available to in the job context has a 0-value `OptimizerFKCascadesLimit`.

This causes DELETE queries run by the job with an inbound on-delete-cascade FK to fail with an error `cascades limit (0) reached`.

This change fixes this by populating OptimizerFKCascadesLimit in `sql.NewFakeSessionData`.

Release note: None

Co-authored-by: Evan Wall <wall@cockroachlabs.com>
@craig craig bot closed this as completed in 1e6c158 Apr 12, 2023
SQL Sessions - Deprecated automation moved this from Triage to Done Apr 12, 2023
@blathers-crl blathers-crl bot mentioned this issue Apr 12, 2023
Closed
blathers-crl bot pushed a commit that referenced this issue Apr 12, 2023
@ecwall
sql: job SessionData OptimizerFKCascadesLimit not defaulting to optDr…
4a52fbf 
…ivenFKCascadesClusterLimit

Fixes #101265

`SessionData` available to in the job context has a 0-value
`OptimizerFKCascadesLimit`.

This causes DELETE queries run by the job with an inbound on-delete-cascade FK
to fail with an error `cascades limit (0) reached`.

This change fixes this by populating OptimizerFKCascadesLimit in
`sql.NewFakeSessionData`.

Release note: None
@blathers-crl blathers-crl bot mentioned this issue Apr 12, 2023
Closed
blathers-crl bot pushed a commit that referenced this issue Apr 12, 2023
@ecwall
sql: job SessionData OptimizerFKCascadesLimit not defaulting to optDr…
cdd8be0 
…ivenFKCascadesClusterLimit

Fixes #101265

`SessionData` available to in the job context has a 0-value
`OptimizerFKCascadesLimit`.

This causes DELETE queries run by the job with an inbound on-delete-cascade FK
to fail with an error `cascades limit (0) reached`.

This change fixes this by populating OptimizerFKCascadesLimit in
`sql.NewFakeSessionData`.

Release note: None
@blathers-crl blathers-crl bot mentioned this issue Apr 12, 2023
Closed
blathers-crl bot pushed a commit that referenced this issue Apr 12, 2023
@ecwall
sql: job SessionData OptimizerFKCascadesLimit not defaulting to optDr…
0c86fac 
…ivenFKCascadesClusterLimit

Fixes #101265

`SessionData` available to in the job context has a 0-value
`OptimizerFKCascadesLimit`.

This causes DELETE queries run by the job with an inbound on-delete-cascade FK
to fail with an error `cascades limit (0) reached`.

This change fixes this by populating OptimizerFKCascadesLimit in
`sql.NewFakeSessionData`.

Release note: None
This was referenced Apr 12, 2023
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ecwall ecwall

Labels
C-bug Code not up to spec/doc, specs & docs deemed correct. Solution expected to change code/behavior. T-sql-foundations SQL Foundations Team (formerly SQL Schema + SQL Sessions)
Projects
No open projects
SQL Sessions - Deprecated
Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

sql: job SessionData OptimizerFKCascadesLimit not defaulting to optDrivenFKCascadesClusterLimit
1 participant
@ecwall