Merge pull request #44347 from yuzefovich/backport19.2-44260

release-19.2: sql: allow booleans in SET tracing and friendlier error message

pkg/sql/conn_executor_exec.go

@@ -1131,13 +1131,22 @@ func (ex *connExecutor) runSetTracing(
 	modes := make([]string, len(n.Values))
 	for i, v := range n.Values {
 		v = unresolvedNameToStrVal(v)
-		strVal, ok := v.(*tree.StrVal)
-		if !ok {
-			res.SetError(errors.AssertionFailedf(
-				"expected string for set tracing argument, not %T", v))
+		var strMode string
+		switch val := v.(type) {
+		case *tree.StrVal:
+			strMode = val.RawString()
+		case *tree.DBool:
+			if *val {
+				strMode = "on"
+			} else {
+				strMode = "off"
+			}
+		default:
+			res.SetError(pgerror.New(pgcode.Syntax,
+				"expected string or boolean for set tracing argument"))
 			return
 		}
-		modes[i] = strVal.RawString()
+		modes[i] = strMode
 	}
 
 	if err := ex.enableTracing(modes); err != nil {

pkg/sql/logictest/testdata/logic_test/set

@@ -302,6 +302,12 @@ SET tracing.blah = 123
 statement error invalid value for parameter "ssl_renegotiation_limit"
 SET ssl_renegotiation_limit = 123
 
+statement ok
+SET SESSION tracing=false
+
+statement error pgcode 42601 expected string or boolean for set tracing argument
+SET SESSION tracing=1
+
 subtest regression_35109_flowable
 
 statement ok