release-19.2: sql: allow booleans in SET tracing and friendlier error message #44347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, we would fail an assertion if a datum of the wrong type is provided in `SET tracing` query (only strings were allowed). This resulted in an internal error and printing out of the stack trace which can be scary to users. This commit removes the assertion and makes it a regular query error. Also, booleans are now allowed as argument to `SET tracing`, and `true` is mapped to `on` mode and `false` to `off`. Release note (sql change, bug fix): Previously, CockroachDB would return an internal error when using `SET tracing` with any type other than string. Now it will return a regular query error. Additionally, boolean arguments are now supported in `SET tracing`, and `true` is mapped to `on` mode of tracing whereas `false` is mapped to `off`.
|
This change is |
|
I don't think we should backport it to 19.1 and 2.1 because in those releases the query in question would not produce an internal error (it was a regular query error back then). |
knz
approved these changes
Jan 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #44260.
/cc @cockroachdb/release
Previously, we would fail an assertion if a datum of the wrong type is
provided in
SET tracingquery (only strings were allowed). This resultedin an internal error and printing out of the stack trace which can be
scary to users. This commit removes the assertion and makes it a regular
query error.
Also, booleans are now allowed as argument to
SET tracing, andtrueis mapped to
onmode andfalsetooff.Fixes: #44244.
Release note (sql change, bug fix): Previously, CockroachDB would return
an internal error when using
SET tracingwith any type other thanstring. Now it will return a regular query error. Additionally, boolean
arguments are now supported in
SET tracing, andtrueis mapped toonmode of tracing whereasfalseis mapped tooff.