-
Notifications
You must be signed in to change notification settings - Fork 3.8k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
cli: enforce inclusion of new crdb_internal tables in debug zip
This is achieved via a unit test. I went through all of the missing tables and made judgement calls on whether they needed to be included. This resulted in the inclusion of some obvious earlier omissions. I also went through the crdb_internal tables and added a naming convention and tried to add TODOs to all methods violating it. It's a bad idea to rename any of these; we should probably alias them to their desired name and leave the old name valid, somehow without listing it in `SHOW TABLES FROM crdb_internal`. Release note (bug fix): Data that was previously omitted from `debug zip` is now included.
- Loading branch information
Showing
4 changed files
with
163 additions
and
43 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.