-
Notifications
You must be signed in to change notification settings - Fork 3.8k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
112661: roachtest: move quota inside test runner r=RaduBerinde a=RaduBerinde Currently the quota is freed by the cluster when it is destroyed. But this is not always what we want, so there is fragile logic around removing the allocation from the cluster before destruction. This change simplifies this by removing the cluster's responsibility for the allocation. Now the main worker loop manages the quota allocation, which makes things a lot simpler. We reorganize the main loop to separately look for a test that can reuse the cluster, and if that fails destroy the cluster and release the allocation before looking for a new test. We now log when we acquire, release, and wait for quota. Epic: none Release note: None 113878: cast_test: add refcursor type r=yuzefovich a=yuzefovich Fixes: #111618. Release note: None 113925: kvserver: remove rangefeed restarter r=erikgrinaker a=erikgrinaker In 2e80942, we added paced rangefeed restarts when changing `kv.rangefeed.scheduler.enabled`. This could result in very uneven rangefeed distributions due to the subsequent retries, which overloaded nodes. We don't have time to properly fix this for 23.2, so we instead remove the restarts and have operators pause/resume the changefeeds when changing the setting. Resolves #112952. Epic: none Release note: None Co-authored-by: Radu Berinde <radu@cockroachlabs.com> Co-authored-by: Yahor Yuzefovich <yahor@cockroachlabs.com> Co-authored-by: Erik Grinaker <grinaker@cockroachlabs.com>
- Loading branch information
Showing
10 changed files
with
223 additions
and
656 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.